Andreas Tolfsen ❲:ato❳ Assignee
	Description • 7 years ago

Because stacktraces from Marionette are broken in 0.19.0 (and
possibly many earlier versions) we will want to get a quick patch
release out there.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 1 • 7 years ago

Andreas, for reference here the changes which went into both webdriver and geckodriver after the last releases:

Webdriver:
% hg log -M -r f0b5f3476d8b:: --template "{desc|firstline}\n" .
Bug 1403503 - Remove obsolete socksUsername and socksPassword capabilities. r=automatedtester
Bug 1407000 - Fix error for string WebDriver capabilities. r=automatedtester
Bug 1407000 - Prefer error messages in the present. r=automatedtester
Bug 1407000 - Lint match_browser. r=automatedtester
Bug 1409438 - Make references to mutable variables immutable. r=whimboo
Bug 1411026 - Provide String type conversion for ErrorStatus. r=whimboo

Geckodriver:
Bug 1400289 - Add geckodriver release instructions. r=automatedtester
Bug 1368034 - Update default values for urlbar searches in Marionette r=whimboo
Bug 1403503 - Remove obsolete socksUsername and socksPassword capabilities. r=automatedtester
Bug 1404891 - Add noProxy documentation for proxy capabilities. r=ato
Bug 1406965 - Add docs on enabling trace logs. r=automatedtester
Bug 1407963 - Sync issue template with GitHub. r=maja_zf
Bug 1407963 - Link to doc/TraceLogs.md from issue template. r=maja_zf
Bug 1407714 - Update geckodriver contribution guide. r=maja_zf
Bug 1407969 - Organise code examples alphabetically. r=maja_zf
Bug 1407969 - Make Ruby example more ergonomic. r=maja_zf
Bug 1407969 - Add C# code example. r=maja_zf
Bug 1407969 - Use FirefoxDriverLogLevel for Java example. r=maja_zf
Bug 1407969 - TLSify Ruby docs links. r=maja_zf
Bug 1408431 - Fix symbol for Selenium logger in Ruby example. r=whimboo
Bug 1409438 - Make references to mutable variables immutable. r=whimboo
Bug 1406212 - Remove references to extensions.e10sBlocksEnabling. r=Felipe
Bug 1410069 - Mention Bugzilla component in contribution advice. r=whimboo
Bug 1409444 - Update rand to 0.3.17. r=manishearth
Bug 1411026 - Rename MarionetteError::status to ::code. r=whimboo
Bug 1411026 - Propagate Marionette stacks to WebDriver error. r=whimboo
Bug 1411363 - Update Cargo.lock files for Rust 1.22. r=froydnj

As it looks like a bit more changes got landed since then. We still have no great new feature, so a minor bugfix release might still be wanted.

	James Graham [:jgraham]
	Comment 7 • 7 years ago
mozreview-review

Comment on attachment 8923446 [details]
Bug 1412037 - Include testing/webdriver as vendored dependency.

https://reviewboard.mozilla.org/r/194602/#review199578

	James Graham [:jgraham]
	Comment 8 • 7 years ago
mozreview-review

Comment on attachment 8923447 [details]
Bug 1412037 - Release webdriver crate 0.32.0.

https://reviewboard.mozilla.org/r/194604/#review199580

	James Graham [:jgraham]
	Comment 9 • 7 years ago
mozreview-review

Comment on attachment 8923448 [details]
Bug 1412037 - Upgrade webdriver dependencies.

https://reviewboard.mozilla.org/r/194606/#review199582

	James Graham [:jgraham]
	Comment 10 • 7 years ago
mozreview-review

Comment on attachment 8923449 [details]
Bug 1412037 - Update changelog.

https://reviewboard.mozilla.org/r/194608/#review199584

	James Graham [:jgraham]
	Comment 11 • 7 years ago
mozreview-review

Comment on attachment 8923450 [details]
Bug 1412037 - Release geckodriver 0.19.1.

https://reviewboard.mozilla.org/r/194610/#review199588

::: testing/geckodriver/Cargo.toml
(Diff revision 1)
>  [package]
>  name = "geckodriver"
> -version = "0.19.0"
> +version = "0.19.1"
> -authors = [

This field is mandatory for publishing to crates.io

	James Graham [:jgraham]
	Comment 12 • 7 years ago

I mean I guess we strictly don't care, but I imagine other tooling will expect a crates-compatible Cargo.toml, so I would like something there even if it's something more generic than specific humans.

	James Graham [:jgraham]
	Comment 14 • 7 years ago
mozreview-review

Comment on attachment 8923450 [details]
Bug 1412037 - Release geckodriver 0.19.1.

https://reviewboard.mozilla.org/r/194610/#review199598

Thanks.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 16 • 7 years ago

(In reply to James Graham [:jgraham] from comment #12)

> I mean I guess we strictly don't care, but I imagine other tooling
> will expect a crates-compatible Cargo.toml, so I would like
> something there even if it's something more generic than specific
> humans.

Assuming you mean “crates.io-compatible Cargo.toml” here.

I don’t really think this is a problem, but I have added another
patch that adds "publish = false" to the Cargo.toml to prevent
geckodriver from accidentally being published to crates.io.

	James Graham [:jgraham]
	Comment 17 • 7 years ago
mozreview-review

Comment on attachment 8923457 [details]
Bug 1412037 - Prevent geckodriver from being published.

https://reviewboard.mozilla.org/r/194612/#review199602

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 18 • 7 years ago

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=35285c930103

	Pulsebot
	Comment 19 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/540273e5cf22
Include testing/webdriver as vendored dependency. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/047b0a0c8312
Release webdriver crate 0.32.0. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/2cb8c9e7040c
Upgrade webdriver dependencies. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/6af08f5a26e7
Update changelog. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/8b34606d8f3b
Release geckodriver 0.19.1. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/b84cdb6df5ea
Prevent geckodriver from being published. r=jgraham

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 20 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/540273e5cf22
https://hg.mozilla.org/mozilla-central/rev/047b0a0c8312
https://hg.mozilla.org/mozilla-central/rev/2cb8c9e7040c
https://hg.mozilla.org/mozilla-central/rev/6af08f5a26e7
https://hg.mozilla.org/mozilla-central/rev/8b34606d8f3b
https://hg.mozilla.org/mozilla-central/rev/b84cdb6df5ea