Andreas Tolfsen ❲:ato❳ Assignee
	Description • 7 years ago

Instead of repeating calls to session.transport.send we can make a
helper function that does the correct HTTP request, like most of the
other tests do.

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 7 • 7 years ago
mozreview-review

Comment on attachment 8921068 [details]
Bug 1410891 - Remove unused imports from Get Active Element WPT test.

https://reviewboard.mozilla.org/r/192040/#review197720

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 8 • 7 years ago
mozreview-review

Comment on attachment 8921069 [details]
Bug 1410891 - Use "is" operator to compare responses.

https://reviewboard.mozilla.org/r/192042/#review197722

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 9 • 7 years ago
mozreview-review

Comment on attachment 8921070 [details]
Bug 1410891 - Use "response" consistently.

https://reviewboard.mozilla.org/r/192044/#review197762

r+wc

::: testing/web-platform/tests/webdriver/tests/element_retrieval/get_active_element.py:68
(Diff revision 1)
>  
> -    assert_result_is_active_element(session, result)
> +    assert_is_active_element(session, response)
>      assert_dialog_handled(session, "dismiss #2")
>      assert read_global(session, "dismiss2") is None
>  
> -    create_dialog(session)("prompt", text="dismiss #3", result_var="dismiss3")
> +    create_dialog(session)("prompt", text="dismiss #3", response_var="dismiss3")

I think you want to keep `result_var` here.

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 10 • 7 years ago
mozreview-review

Comment on attachment 8921071 [details]
Bug 1410891 - Fix prompt handle assertions.

https://reviewboard.mozilla.org/r/192046/#review197764

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 11 • 7 years ago
mozreview-review

Comment on attachment 8921072 [details]
Bug 1410891 - Use a command helper function.

https://reviewboard.mozilla.org/r/192048/#review197766

::: commit-message-3c3dc:3
(Diff revision 1)
> +Bug 1410891 - Use a command helper function. r?maja_zf
> +
> +Instead of repeating to session.transport.send we can use a helper

repeating -calls- to?

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 12 • 7 years ago
mozreview-review

Comment on attachment 8921073 [details]
Bug 1410891 - Assert that "value" is in response.

https://reviewboard.mozilla.org/r/192050/#review197768

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 13 • 7 years ago
mozreview-review-reply

Comment on attachment 8921072 [details]
Bug 1410891 - Use a command helper function.

https://reviewboard.mozilla.org/r/192048/#review197766

> repeating -calls- to?

Yes, thanks.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 14 • 7 years ago
mozreview-review-reply

Comment on attachment 8921070 [details]
Bug 1410891 - Use "response" consistently.

https://reviewboard.mozilla.org/r/192044/#review197762

> I think you want to keep `result_var` here.

Good thing you spotted this.

	Pulsebot
	Comment 21 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/765fd4dad6c6
Remove unused imports from Get Active Element WPT test. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/4dacaa19ecf1
Use "is" operator to compare responses. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/f874db15ddb1
Use "response" consistently. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/2252020d2813
Fix prompt handle assertions. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/e9143b9171f5
Use a command helper function. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/ba5c4c248d02
Assert that "value" is in response. r=maja_zf

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 22 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/765fd4dad6c6
https://hg.mozilla.org/mozilla-central/rev/4dacaa19ecf1
https://hg.mozilla.org/mozilla-central/rev/f874db15ddb1
https://hg.mozilla.org/mozilla-central/rev/2252020d2813
https://hg.mozilla.org/mozilla-central/rev/e9143b9171f5
https://hg.mozilla.org/mozilla-central/rev/ba5c4c248d02