Closed Bug 1409031 Opened 7 years ago Closed 7 years ago

Fix testing/marionette/element.js API docs

Categories

(Remote Protocol :: Marionette, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(5 files)

In particular element.findByLinkText and element.isCollection is wrong.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Blocks: 1400256
Comment on attachment 8918876 [details]
Bug 1409031 - Fix element.findByLinkText docs.

https://reviewboard.mozilla.org/r/189746/#review194924
Attachment #8918876 - Flags: review?(hskupin) → review+
Comment on attachment 8918877 [details]
Bug 1409031 - Document element.isCollection.

https://reviewboard.mozilla.org/r/189748/#review194926
Attachment #8918877 - Flags: review?(hskupin) → review+
Comment on attachment 8918878 [details]
Bug 1409031 - Correct markup for element.getContainer docs.

https://reviewboard.mozilla.org/r/189750/#review194928
Attachment #8918878 - Flags: review?(hskupin) → review+
Comment on attachment 8918879 [details]
Bug 1409031 - Fix element.isInView markup.

https://reviewboard.mozilla.org/r/189752/#review194930
Attachment #8918879 - Flags: review?(hskupin) → review+
Comment on attachment 8918880 [details]
Bug 1409031 - Fix element.isBooleanAttribute markup.

https://reviewboard.mozilla.org/r/189754/#review194932

A single commit for all of those changes would have been enough. :)
Attachment #8918880 - Flags: review?(hskupin) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea557e47e8fb
Fix element.findByLinkText docs. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/427e0f009476
Document element.isCollection. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/02b7cd86d7f3
Correct markup for element.getContainer docs. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/8f74bad95043
Fix element.isInView markup. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/cc49fa0da9d3
Fix element.isBooleanAttribute markup. r=whimboo
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: