Bob Silverberg [:bsilverberg] Assignee
	Description • 7 years ago

I am spinning this off from bug 1371793 because that is more general being about the ability to create a number of different types of about: URLs.

For the reader mode API support we are only interested in the ability to call tabs.create with an about:reader URL, so I am narrowing the scope for this bug. Some discussion has already occurred in bug 1371793, and a security review has been opened via bug 1390035.

	Bob Silverberg [:bsilverberg] Assignee
	Comment 2 • 7 years ago

Note that this is still awaiting a security review (bug 1390035), but if we can finalize the implementation via this bug that might help facilitate the sec-review.

	Andrew Swan [:aswan]
	Comment 3 • 7 years ago

Is the proposal that extensions actually constructor about:reader urls?  I think that if we can avoid exposing the url structure that would be good, since there's now a reader more property in Tab objects, how about just adding the same property to create options and creating an appropriate reader url if it is set to true?

	Bob Silverberg [:bsilverberg] Assignee
	Comment 4 • 7 years ago

(In reply to Andrew Swan [:aswan] from comment #3)
> Is the proposal that extensions actually constructor about:reader urls?  I
> think that if we can avoid exposing the url structure that would be good,
> since there's now a reader more property in Tab objects, how about just
> adding the same property to create options and creating an appropriate
> reader url if it is set to true?

That is a very good idea. I will update the patch accordingly.

	Shane Caraveo (:mixedpuppy)
	Comment 6 • 7 years ago
mozreview-review

Comment on attachment 8918916 [details]
Bug 1408993 - Allow tabs.create to create URLS in reader mode,

https://reviewboard.mozilla.org/r/189816/#review194962

r+ with fix

::: browser/components/extensions/ext-tabs.js:351
(Diff revision 2)
>                if (!context.checkLoadURL(url, {dontReportErrors: true})) {
>                  return Promise.reject({message: `Illegal URL: ${url}`});
>                }
> +
> +              if (createProperties.openInReaderMode) {
> +                url = `about:reader?url=${url}`;

${encodeURIComponent(url)}

	Bob Silverberg [:bsilverberg] Assignee
	Comment 8 • 7 years ago
mozreview-review-reply

Comment on attachment 8918916 [details]
Bug 1408993 - Allow tabs.create to create URLS in reader mode,

https://reviewboard.mozilla.org/r/189816/#review194962

> ${encodeURIComponent(url)}

Thanks Shane.

	Pulsebot
	Comment 10 • 7 years ago

Pushed by bsilverberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/beb6d23925c0
Allow tabs.create to create URLS in reader mode, r=mixedpuppy

	Stefan Hindli [:stefan_hindli]
	Comment 11 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/beb6d23925c0

	Will Bamberg [:wbamberg]
	Comment 12 • 7 years ago

See: https://bugzilla.mozilla.org/show_bug.cgi?id=1381992#c54 for links to the docs.

	Victor Carciu
	Comment 13 • 7 years ago

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!