Cameron McCormack (:heycam) Reporter
	Description • 7 years ago

We should look into whether we can safely unship CSSStyleDeclarationValue::getPropertyCSSValue, or at least greatly simplify the kinds of objects that we return.  According to MDN, WebKit is the only other engine that supports this method, but I haven't done any web compat investigations myself.

This would simplify bug 1408300.

	Firefox Bug Husbandry Bot
	Comment 1 • 6 years ago

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 2 • 6 years ago

Back in bug 474655 I tried to land a deprecation warning, but IIRC our chrome hit it too much.

	Jonathan Watt [:jwatt]
	Comment 3 • 6 years ago

Jumping the gun somewhat, but here's a patch in the event that we can move forward with this.

	Jonathan Watt [:jwatt]
	Comment 4 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28ab76af261143e4604beedbec68ab44bc7602d7

	Emilio Cobos Álvarez (:emilio) Assignee
	Comment 5 • 6 years ago

So, usage in nightly looks not high (0.005%) so far according to:

  https://georgf.github.io/usecounters/index.html#kind=document&group=DEPRECATED&channel=nightly&version=61

That is non-zero though. After talking with Boris I think it makes sense to disable on nightly and see if it breaks something, and only get data from beta for this use counter.

	Emilio Cobos Álvarez (:emilio) Assignee
	Comment 7 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8d91bd3025bcf867a0165cd56d388a5fdbf020f

	Boris Zbarsky [:bzbarsky]
	Comment 8 • 6 years ago
mozreview-review

Comment on attachment 8973967 [details]
Bug 1408301: Remove getPropertyCSSValue.

https://reviewboard.mozilla.org/r/242312/#review249040

r=me, but do you mind filing a followup for those various editor things whose comments you are removing to use the CSS Typed OM once it exists?  Probably depending on the bug for CSS Typed OM if we have it...

	Pulsebot
	Comment 9 • 6 years ago

Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f0eb5c180c1
Remove getPropertyCSSValue. r=bz

	Emilio Cobos Álvarez (:emilio) Assignee
	Comment 10 • 6 years ago

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #8)
> Comment on attachment 8973967 [details]
> Bug 1408301: Remove getPropertyCSSValue.
> 
> https://reviewboard.mozilla.org/r/242312/#review249040
> 
> r=me, but do you mind filing a followup for those various editor things
> whose comments you are removing to use the CSS Typed OM once it exists? 
> Probably depending on the bug for CSS Typed OM if we have it...

Filed a couple bugs depending on bug 1278697.

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 11 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/6f0eb5c180c1

	Kohei Yoshino [:kohei]
	Comment 12 • 6 years ago

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/cssstyledeclaration-getpropertycssvalue-has-been-removed/

	Will Bamberg [:wbamberg]
	Comment 13 • 6 years ago

Compat data is updated for this: https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleDeclaration/getPropertyCSSValue#Browser_compatibility, marking dev-doc-complete.