Closed
Bug 1408062
Opened 7 years ago
Closed 6 years ago
Show that a hidden tab is making sound
Categories
(WebExtensions :: Frontend, defect, P1)
WebExtensions
Frontend
Tracking
(firefox57 wontfix, firefox59 disabled, firefox60 disabled, firefox61+ verified)
VERIFIED
FIXED
mozilla61
People
(Reporter: andy+bugzilla, Assigned: mstriemer)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
If a tab is hidden there is no indication to the user that the hidden tab is not making any sound, since that visual notification is on the tab.
Reporter | ||
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Priority: -- → P2
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → mstriemer
This is probably not the right place, but here goes: Firefox should natively have a way to either mute the entire browser or mute all tabs individually at once. This is for the UI team first and foremost.
Reporter | ||
Comment 2•6 years ago
|
||
(In reply to Hlsg from comment #1) Please file a bug in Firefox for this feature request. https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox
(In reply to Andy McKay [:andym] from comment #2) > (In reply to Hlsg from comment #1) > Please file a bug in Firefox for this feature request. > https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox Done. For reference: https://bugzil.la/1435513
My bug was duped with this one: https://bugzil.la/1301099 The reason why I'm mentioning this here is that I believe that the UI team should consider merging these functionalities in a single element.
Comment hidden (abuse-reviewed, advocacy) |
Comment hidden (abuse-reviewed, advocacy) |
Assignee | ||
Comment 7•6 years ago
|
||
When there is a hidden tab playing audio there should be an audio indicator on the all tabs toolbarbutton. Any tabs playing audio should also be brought up to the main level of the all tabs dropdown underneath the Hidden Tabs sub menu. These tabs should still be included in the Hidden Tabs sub menu.
status-firefox61:
--- → affected
tracking-firefox61:
--- → ?
Assignee | ||
Updated•6 years ago
|
Priority: P2 → P1
Comment 8•6 years ago
|
||
Required to ship the new tab hiding api without being behind a pref. Tracking61+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 10•6 years ago
|
||
Here's a gif showing the interaction.
Comment hidden (mozreview-request) |
Comment 12•6 years ago
|
||
mozreview-review |
Comment on attachment 8970213 [details] Bug 1408062 - Show hidden tabs that are playing audio https://reviewboard.mozilla.org/r/238960/#review245404 ::: browser/base/content/tabbrowser.xml:2187 (Diff revision 2) > > // Listen for changes in the tab bar. > tabcontainer.addEventListener("TabAttrModified", this); > tabcontainer.addEventListener("TabClose", this); > > - let tabs = gBrowser.visibleTabs; > + let tabs = showHiddenTabs ? gBrowser.tabs : gBrowser.visibleTabs; Seems like you could just always use gBrowser.tabs here at this point? ::: browser/themes/shared/tabs.inc.css:731 (Diff revision 2) > + color: inherit; > + display: block; > + /* "!important" is necessary to override the rule in toolbarbutton.css */ > + margin: -7px 0 0 !important; > + margin-inline-end: -4px !important; > + mask-image: url(chrome://browser/skin/tabbrowser/badge-audio-playing.svg); That's a neat idea, but we should just use -moz-context-properties: fill; and fill: currentColor; here, and fill="context-fill" in the SVG.
Attachment #8970213 -
Flags: review?(dao+bmo) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 14•6 years ago
|
||
mozreview-review |
Comment on attachment 8970213 [details] Bug 1408062 - Show hidden tabs that are playing audio https://reviewboard.mozilla.org/r/238960/#review245420 Thanks for the review!
Assignee | ||
Comment 15•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8970213 [details] Bug 1408062 - Show hidden tabs that are playing audio https://reviewboard.mozilla.org/r/238960/#review245404 > Seems like you could just always use gBrowser.tabs here at this point? Good call, I also cleaned up the `if`s here so they didn't need to nest so deeply. > That's a neat idea, but we should just use -moz-context-properties: fill; and fill: currentColor; here, and fill="context-fill" in the SVG. Ah, yeah that would be better. I updated the icon and switched to using `-moz-context-properties` and a `background`.
Comment 16•6 years ago
|
||
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f55f15b26569 Show hidden tabs that are playing audio r=dao
Comment 17•6 years ago
|
||
Backed out changeset f55f15b26569 (bug 1408062) for Browser-chrome failure on browser/base/content/test/general/browser_audioTabIcon.js. CLOSED TREE Log: https://treeherder.mozilla.org/logviewer.html#?job_id=175580125&repo=autoland&lineNumber=2314 INFO - TEST-PASS | browser/base/content/test/general/browser_audioTabIcon.js | There are no hidden audio tabs - [task 2018-04-25T19:37:20.592Z] 19:37:20 INFO - Buffered messages finished [task 2018-04-25T19:37:20.593Z] 19:37:20 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_audioTabIcon.js | The audio playing icon is shown - Got none, expected url("chrome://browser/skin/tabbrowser/badge-audio-playing.svg") [task 2018-04-25T19:37:20.593Z] 19:37:20 INFO - Stack trace: [task 2018-04-25T19:37:20.594Z] 19:37:20 INFO - chrome://mochikit/content/browser-test.js:test_is:1285 [task 2018-04-25T19:37:20.594Z] 19:37:20 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_audioTabIcon.js:test_playing_icon_on_hidden_tab:289 Push with the fail: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f55f15b265698d4cc7cb7a290272eba16c694a1b Backout: https://hg.mozilla.org/integration/autoland/rev/87d1da02c6dad63025185385ba457937ffd1ee5b
Flags: needinfo?(mstriemer)
Comment hidden (mozreview-request) |
Comment 19•6 years ago
|
||
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/356d8af4a2b9 Show hidden tabs that are playing audio r=dao
Comment 20•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/356d8af4a2b9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(mstriemer)
Comment 21•6 years ago
|
||
Tested and reproduced in Firefox 60.0a1 (20180303220113). Retested and verified in Firefox 61.0a1 (20180430100522)
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•