Closed Bug 1407925 Opened 7 years ago Closed 7 years ago

Checks for Firefox should not use application name but application ID

Categories

(Remote Protocol :: Marionette, enhancement, P5)

Product:
Remote Protocol
Component:
Marionette
Version:
57 Branch
Type:
enhancement

Tracking

(firefox-esr52 wontfix, firefox57 fixed, firefox58 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox-esr52 --- wontfix
firefox57 --- fixed
firefox58 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

Details

Attachments

(1 file)

Bug 1407925 - Don't use application name but ID to determine Firefox.
59 bytes, text/x-review-board-request
ato
: review+
Details 
Right now assert.isFirefox relies on the application name to determine if it is Firefox or not. This is wrong given that it should instead check against the application ID.

Fixing this would allow distributors who make changes to Firefox and release it under a different name to still use Marionette / Selenium to run tests.

It's a simple change which we should uplift to all supported branches.
OS: Unspecified → All
Priority: -- → P5
Hardware: Unspecified → All
There is actually also other code outside of assert.js which is using the name instead of the id.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Summary: assert.isFirefox should not rely on application name but application ID → Checks for Firefox should not use application name but application ID
Attachment #8917793 - Flags: review?(ato)
Comment on attachment 8917793 [details]
Bug 1407925 - Don't use application name but ID to determine Firefox.

https://reviewboard.mozilla.org/r/188732/#review194130
Attachment #8917793 - Flags: review?(ato) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97bf696997c5
Don't use application name but ID to determine Firefox. r=ato
https://hg.mozilla.org/mozilla-central/rev/97bf696997c5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Please uplift the test-only changes to both the beta and esr52 branch.
Whiteboard: [checkin-needed-beta][checkin-needed-esr52]
https://hg.mozilla.org/releases/mozilla-beta/rev/13bdb1a613e5
status-firefox57: affected → fixed
Whiteboard: [checkin-needed-beta][checkin-needed-esr52] → [checkin-needed-esr52]
Needs a rebased patch for ESR52.
Flags: needinfo?(hskupin)
Whiteboard: [checkin-needed-esr52]
So lets leave as it is right now. No need to work on a rebased patch for the 52esr branch.
status-firefox-esr52: affected → wontfix
Flags: needinfo?(hskupin)
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: