Chuong Duong Reporter
	Description • 7 years ago

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171010220102

Steps to reproduce:

1. Open developer toolbar
2. Click Network tab
3. Right click on a request in the list
4. Click on "Open in new tab".


Actual results:

It does not send any POST parameters


Expected results:

The page should open WITH whole POST parameters as same as original. This feature is as same as FireBug and it very helpful for debug ajax request.

	Sebastian Zartner [:sebo]
	Comment 1 • 6 years ago

Honza, isn't that the same as bug 1220758?

Sebastian

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 2 • 6 years ago

Alternate STR (from bug 1220758)

1. Go to http://codebad.com/~hdon/firefox-bug.php
2. Open Developers Tools' Network tab.
3. Click "submit" button.
4. Open context menu (right click) the Network tab's representation of the enusing HTTP request.
5. Select "Open in New Tab."

Honza

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 3 • 6 years ago

@Abhinav, do you want to take a look at this?

Some comments:

1) openRequestInTab is implemented in
netmonitor\src\utils\firefox\open-request-in-tab.js

2) It doesn't work the first time since `request.requestPostData` is not available.

3) It works second time (following STR from comment #2) since data has been fetched.

4) See netmonitor/src/widgets/RequestListContextMenu.js 
There is `copyPostData` method that uses `connector.requestData` to fetch "requestPostData"
before copying the value into the clipboard. Something similar should be done in `openRequestInTab`,
which is also in RequestListContextMenu.js file.

Honza

	Chuong Duong Reporter
	Comment 4 • 6 years ago

(In reply to Jan Honza Odvarko [:Honza] from comment #2)
> Alternate STR (from bug 1220758)
> 
> 1. Go to http://codebad.com/~hdon/firefox-bug.php
> 2. Open Developers Tools' Network tab.
> 3. Click "submit" button.
> 4. Open context menu (right click) the Network tab's representation of the
> enusing HTTP request.
> 5. Select "Open in New Tab."
> 
> Honza

It doesn't fix this issue, the POST parameter still missing.
After follow the step 5, my browser show the new tab but that page says: "Your HTTP request method was: GET. "

It does not only missed the post parameter but also changed method from POST to GET.

	Abhinav Koppula
	Comment 5 • 6 years ago

Hi Honza,
Sure, I can take a look at this.

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 6 • 6 years ago

Assigned to you, thanks!
Honza

	Chuong Duong Reporter
	Comment 7 • 6 years ago

(In reply to Abhinav Koppula from comment #5)
> Hi Honza,
> Sure, I can take a look at this.

Thanks

	Code Review Bot [:reviewbot]
	Comment 11 • 6 years ago
mozreview-review

Comment on attachment 8963855 [details]
Bug 1407515 - more detailed test of Open in New Tab

https://reviewboard.mozilla.org/r/232720/#review238150


Code analysis found 2 defects in this patch:
 - 2 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/netmonitor/test/browser_net_open_request_in_tab.js:88
(Diff revision 1)
> +    document.querySelector(".network-details-panel-toggle"));
> +    EventUtils.sendMouseEvent({ type: "click" },
> +      document.querySelector("#security-tab"));
> +    await waitUntil(() => document.querySelector(
> +      "#security-panel .security-info-value"));
> +    };

Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy]

::: devtools/client/netmonitor/test/browser_net_open_request_in_tab.js:88
(Diff revision 1)
> +    document.querySelector(".network-details-panel-toggle"));
> +    EventUtils.sendMouseEvent({ type: "click" },
> +      document.querySelector("#security-tab"));
> +    await waitUntil(() => document.querySelector(
> +      "#security-panel .security-info-value"));
> +    };

Error: Unnecessary semicolon. [eslint: no-extra-semi]

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 15 • 6 years ago
mozreview-review

Comment on attachment 8963853 [details]
Bug 1407515 - make sure post data is suplied to Open in New Tab

https://reviewboard.mozilla.org/r/232716/#review238448

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 16 • 6 years ago
mozreview-review

Comment on attachment 8963854 [details]
Bug 1407515 - simplify Open in New Tab in launchpad

https://reviewboard.mozilla.org/r/232718/#review238450

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 17 • 6 years ago
mozreview-review

Comment on attachment 8963855 [details]
Bug 1407515 - more detailed test of Open in New Tab

https://reviewboard.mozilla.org/r/232720/#review238452

Thanks for the patch!

Just couple of inline comments.

Honza

::: devtools/client/netmonitor/test/browser_net_open_request_in_tab.js:21
(Diff revision 4)
>    let Actions = windowRequire("devtools/client/netmonitor/src/actions/index");
> +  let newTab;
>  
>    store.dispatch(Actions.batchEnable(false));
>  
> -  // Execute requests.
> +  // Post data may be fetched for other componentes (eg. headers panel)

Typo: componentes -> components

::: devtools/client/netmonitor/test/browser_net_open_request_in_tab.js:23
(Diff revision 4)
>  
>    store.dispatch(Actions.batchEnable(false));
>  
> -  // Execute requests.
> -  await performRequests(monitor, tab, 1);
> +  // Post data may be fetched for other componentes (eg. headers panel)
> +  // and as a side-effect in those situation hide existing bug (Bug 1407515)
> +  await changeDefaultDetailsPanel;

Could you just change the default tab?

store.getState().ui.detailsPanelSelectedTab = "security" ?

::: devtools/client/netmonitor/test/browser_net_open_request_in_tab.js:23
(Diff revision 4)
>  
>    store.dispatch(Actions.batchEnable(false));
>  
> -  // Execute requests.
> -  await performRequests(monitor, tab, 1);
> +  // Post data may be fetched for other componentes (eg. headers panel)
> +  // and as a side-effect in those situation hide existing bug (Bug 1407515)
> +  await changeDefaultDetailsPanel;

That comment shouldn't took the bug 1407515 as a reason. The bug will be fixed one day and it become obsolete.

It should rather say something like:

Post data may be fetched by the Header panel, so set the Security panel as the new default.

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 19 • 6 years ago
mozreview-review

Comment on attachment 8963855 [details]
Bug 1407515 - more detailed test of Open in New Tab

https://reviewboard.mozilla.org/r/232720/#review238838

Looks great, thanks for the patch!
(just one inline nit comment)

R+ assuming try is green

Honza

::: devtools/client/netmonitor/test/sjs_method-test-server.sjs:15
(Diff revision 5)
> +function handleRequest(request, response) {
> +  response.setStatusLine(request.httpVersion, 200, "Och Aye");
> +  response.setHeader("Content-Type", "text/plain; charset=utf-8", false);
> +
> +  var body = request.method + "\n" ;
> +  if (request.method == 'POST') {

nit: use quotes -> "POST"

	Tom Glowka Assignee
	Comment 21 • 6 years ago

(In reply to Jan Honza Odvarko [:Honza] from comment #19)

> R+ assuming try is green

Yep, it is https://treeherder.mozilla.org/#/jobs?repo=try&revision=276fadc600eafa352f3065a36ca19d7f931f7a1a

	Pulsebot
	Comment 22 • 6 years ago

Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4213a293a540
make sure post data is suplied to Open in New Tab r=Honza
https://hg.mozilla.org/integration/autoland/rev/52216da191ea
simplify Open in New Tab in launchpad r=Honza
https://hg.mozilla.org/integration/autoland/rev/1debc4ccf15b
more detailed test of Open in New Tab r=Honza

	Andrei Ciure[:aciure]
	Comment 23 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/4213a293a540
https://hg.mozilla.org/mozilla-central/rev/52216da191ea
https://hg.mozilla.org/mozilla-central/rev/1debc4ccf15b

	info
	Comment 24 • 6 years ago

it is fixed? 
when will the fix be included in nightly? 
still not working in 2018-04-12...

	Tom Glowka Assignee
	Comment 25 • 6 years ago

Hey, thanks for reporting, can you please describe steps to reproduce the bug?

I also tried to reproduce the bug using steps from comment #2 on nightly 2018-04-09 and 2018-04-12 and I did not manage to. Do the steps below reproduce the bug for you? 
> Alternate STR (from bug 1220758)
> 
> 1. Go to http://codebad.com/~hdon/firefox-bug.php
> 2. Open Developers Tools' Network tab.
> 3. Click "submit" button.
> 4. Open context menu (right click) the Network tab's representation of the
> enusing HTTP request.
> 5. Select "Open in New Tab."

	info
	Comment 26 • 6 years ago

1. Go to http://xhrbug.fisdev.de
2. Open Developers Tools Console tab.
3. Open context menu (right click) on the XHR request
4. Select "Open in New Tab."

	Tom Glowka Assignee
	Comment 27 • 6 years ago

Thanks for that STR, but I am not able to reproduce it.  After selecting XHR request and clicking "Open in New Tab" I get "REQUEST_METHOD was POST". Again both nightly 2018-04-09 and 2018-04-12. 

Anyone can reproduce that?

	info
	Comment 28 • 6 years ago

:-( http://xhrbug.fisdev.de/xhrbug.jpg
!?!?!

	Tom Glowka Assignee
	Comment 29 • 6 years ago

Now I see that in the picture. Thanks for attaching it! Just after looking at your screen picture I realized I had overlooked point 2 from your comment #26 STR in which you mention "Developers Tools Console" tab.
So firstly I can reproduce it now and secondly I think you are in fact reporting new bug. This one was related to "Developers Tools Netmonitor" tab which also has "Open in New Tab" functionality, but is quite different piece of code.

Can you take STR from comment #26 and create the new bug for "Developers Tools Console" component?

	Chris Mills [:cmills]
	Comment 30 • 6 years ago

I added a note to the Fx61 rel notes:
https://developer.mozilla.org/en-US/Firefox/Releases/61#Developer_tools

I also updated a note in the network monitor page to mention this issue:
https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor#Open_in_New_Tab

Does this look Ok?

	omid rad
	Comment 31 • 6 years ago

It doesn't work properly if content type of the request is "application/json".

In my test case, I sent "{"email":"email@example.com","password":"text&with&ampersand&in&it!"}" with "application/json" content type.

But when I open it in a new tab, it will send "application/x-www-form-urlencoded" content type which will be interpreted as:

{"email":"email@example.com","password":"text
with
ampersand
in
it!"}

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 32 • 6 years ago

@omid: please create a new report, this one is alrwady closed.
I'll investigate it,
Thanks!

Honza