Andreas Tolfsen ❲:ato❳ Assignee
	Description • 7 years ago

The browserName, browserVersion, and platformName capabilities
return an error message saying the value "was not a boolean" when it
is not a string.  This is obviously meant to be "not a string".

>                 x @ "browserName" |
>                 x @ "browserVersion" |
>                 x @ "platformName" => if !value.is_string() {
>                         return Err(WebDriverError::new(ErrorStatus::InvalidArgument,
>                                                       format!("{} was not a boolean", x)))
>                     },

	David Burns :automatedtester
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8916710 [details]
Bug 1407000 - Fix error for string WebDriver capabilities.

https://reviewboard.mozilla.org/r/187790/#review193074

	David Burns :automatedtester
	Comment 5 • 7 years ago
mozreview-review

Comment on attachment 8916711 [details]
Bug 1407000 - Prefer error messages in the present.

https://reviewboard.mozilla.org/r/187792/#review193076

	David Burns :automatedtester
	Comment 6 • 7 years ago
mozreview-review

Comment on attachment 8916712 [details]
Bug 1407000 - Lint match_browser.

https://reviewboard.mozilla.org/r/187794/#review193078

	David Burns :automatedtester
	Comment 7 • 7 years ago
mozreview-review

Comment on attachment 8916711 [details]
Bug 1407000 - Prefer error messages in the present.

https://reviewboard.mozilla.org/r/187792/#review193080

	Pulsebot
	Comment 8 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bcd6572f47d
Fix error for string WebDriver capabilities. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/5caa7a4686ab
Prefer error messages in the present. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/8751f6fd0421
Lint match_browser. r=automatedtester

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 9 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/3bcd6572f47d
https://hg.mozilla.org/mozilla-central/rev/5caa7a4686ab
https://hg.mozilla.org/mozilla-central/rev/8751f6fd0421