Expanded variables are collapsed again after every step
Categories
(DevTools :: Debugger, defect, P2)
Tracking
(firefox70 fixed)
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: bugzzilla, Assigned: bhackett1024)
References
(Blocks 1 open bug)
Details
(Whiteboard: [debugger-mvp])
Attachments
(2 files)
14.18 KB,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 Build ID: 20170926190823 Steps to reproduce: 1. Set breakpoint, run into breakpoint 2. Find object variable, expand it 3. Make single step Actual results: Expanded variables are collapsed again Expected results: Expanded variables should stay expanded
Updated•7 years ago
|
Comment 1•7 years ago
|
||
Thanks for reporting! I am moving this over to the devtools core repo to be investigated.
Comment 2•7 years ago
|
||
https://github.com/devtools-html/devtools-core/issues/744 tracking here
Updated•7 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Comment 3•6 years ago
|
||
I see this as well on latest nightly. New issue for tracking this: https://github.com/devtools-html/debugger.html/issues/6897
Updated•6 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
This patch remembers the paths of expanded scope items (including sub-objects) in the debugger's reducer and uses those to re-expand the same paths after unpausing and pausing somewhere else. The main limitation of this is that when stepping from one scope to another the paths will be collapsed again, even for variables that are still in scope. This could be improved some more but seems a good place to work from for now. Unfortunately this patch isn't ready for review because changes are needed to the Tree and ObjectInspector components of the devtools-reps repo, which is hosted on github instead of m-c.
Assignee | ||
Comment 7•5 years ago
|
||
Hmm, the devtools-reps repo no longer exists (and the README in m-c is out of date). ObjectInspector is in the firefox-devtools component but Tree does not seem to be. I don't know how to get these changes landed.
Comment 8•5 years ago
|
||
(In reply to Brian Hackett (:bhackett) from comment #6)
changes are needed to the Tree and ObjectInspector components of the devtools-reps repo, which is hosted on github instead of m-c.
I think you can just land the changes in m-c and darkwing will export the changes to github.
But you shouldn't edit devtools/client/shared/components/reps/reps.js
directly, instead change devtools/client/debugger/packages/devtools-components/src/tree.js
and devtools/client/debugger/packages/devtools-reps/src/object-inspector/components/ObjectInspector.js
.
Then use cd devtools/client/debugger && npm install && node bin/bundle.js
to generate the reps.js
Comment 9•5 years ago
•
|
||
Yep - i second oriol's advice. I also second your approach, this is exactly what I was planning on doing.
Updated•5 years ago
|
Assignee | ||
Comment 10•5 years ago
|
||
Assignee | ||
Comment 11•5 years ago
|
||
Thanks for the help Oriol, the patch above modifies the package files and includes the corresponding reps.js changes as well.
Comment 12•5 years ago
|
||
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/03df8624c36c Re-expand scope entries after resuming and re-pausing in a frame, r=jlast.
Comment 13•5 years ago
|
||
Backed out 3 changesets (bug 1556847, bug 1556858, bug 1405402) for eslint failures at /actors/replay/debugger.js on a CLOSED TREE.
Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/756e8d09a98ff8869a8065337e1f2d2f9816e126
Pushes with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&revision=1bf0b6a8dd1309ee22bd5b3593ca150172b644a9&selectedJob=257596995
Log snippet:
[task 2019-07-21T18:16:52.027Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-07-21T18:16:52.027Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-07-21T18:16:52.027Z]
[task 2019-07-21T18:16:52.027Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-07-21T18:33:27.238Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/replay/debugger.js:548:28 | Insert ??????? (prettier/prettier)
[task 2019-07-21T18:33:27.238Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/replay/debugger.js:549:7 | Replace type:?"getSource", with ??type:?"getSource",???????? (prettier/prettier)
[task 2019-07-21T18:33:27.238Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/replay/debugger.js:550:1 | Replace ????}) with ??????})????? (prettier/prettier)
[taskcluster 2019-07-21 18:33:27.578Z] === Task Finished ===
[taskcluster 2019-07-21 18:33:28.586Z] Unsuccessful task run with exit code: 1 completed in 1368.153 seconds
Comment 14•5 years ago
|
||
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/46499a50b778 Re-expand scope entries after resuming and re-pausing in a frame, r=jlast.
Comment 15•5 years ago
|
||
bugherder |
Description
•