Ben Kelly [:bkelly, not reviewing] Reporter
	Description • 7 years ago

I noticed I had a leaked browser.xul today.  I grabbed the GC/CC logs and it showed it was being held alive by:

via ScriptPreloader::CachedScript.mScript :
000001FA7DA91680 [script chrome://browser/content/browser-addons.js:]
    --[objects[3]]--> 000001FA7DA9A380 [Function showInstallConfirmation]
    --[group]--> 000001FA7DA923D0 [object_group]
    --[group_global]--> 000001FA77023060 [Window <no private>]

I suspect this is fallout from trying to install an addon in 57 that is not compatible with web extensions.  I got the "could not install" error message because of the version mismatch.

And if this is another "xul script cache just leaks" thing, I have to say I'm not thrilled.  How are we supposed to find real leaks if we're chasing false positives from the script cache all the time?

	:Gijs (he/him)
	Comment 1 • 7 years ago

Fx::General is unfortunately not a place where this bug is (or really, most bugs are) very visible. Are you looking into this? If not and you expect / would like someone else to do so, it might get more traction in e.g. Toolkit :: Addons Manager (which is effectively kind of responsible for these dialogs and so on, as part of the add-on install/management experience).

	Ben Kelly [:bkelly, not reviewing] Reporter
	Comment 2 • 7 years ago

I looked in hg log to see last bug that changed this file that wasn't widespread changes.  It was in Firefox general.

I'm not actively working this.

Please triage it to whatever component owns browser-addon.js.

	:Gijs (he/him)
	Comment 3 • 7 years ago

(In reply to Ben Kelly [:bkelly] from comment #2)
> I looked in hg log to see last bug that changed this file that wasn't
> widespread changes.  It was in Firefox general.
> 
> I'm not actively working this.
> 
> Please triage it to whatever component owns browser-addon.js.

Dave, what's a good place for something like this?