Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Description • 7 years ago

Given that this is only the folder name which gives us inconsistencies with the actual package name, and that it confuses me all the time, I would like to get this fixed.

I assume only changes to the build system are necessary here.

	Andreas Tolfsen ❲:ato❳
	Comment 3 • 7 years ago

Comment on attachment 8910236 [details]
Bug 1401510 - Rename testing/marionette/client to testing/marionette/driver.

Historically, only remote end implementations have been known as
‘drivers’ as a way to recognise that they fulfill the WebDriver
interface.  I would argue that it is factually incorrect for the
Marionette Python client to bear this name since it only implements
a client for said interface: it does not actually “drive”
anything.

We have previously changed the name from testing/marionette/driver
to testing/marionette/client exactly because “driver” was
confusing.  At the time we lamented the fact that the package was
named marionette_driver in the PyPI, but regrettably it is not easy
to change a package’s name when it is much-used out-of-tree.

Recognising this mistake, we put the client under
testing/marionette/client but have kept the marionette_driver
package name because we are not yet ready to yank it from PyPI or
move on to a better WebDriver-conforming client.

I am also concerned that links to the source code and version
control history will be harder to follow as a result of this change.
I’m opposed to this change for these reasons, and I think our
time is better spent moving us off the Marionette Python client
altogether, in favour of a more modern client with a better API that
can be used interoperably with other WebDriver implementations.

	James Graham [:jgraham]
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8910237 [details]
Bug 1401510 - Remove fallback imports for marionette driver in wpt-runner.

https://reviewboard.mozilla.org/r/181720/#review187982

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 5 • 7 years ago

Andreas, I know this discussion. Generally I'm the one who releases new packages, and each time I really run again into the naming confusions. If we are not going to rename the package, then please let us revert the name to be at least consistent with the package. Mercurial is smart enough to allow you to go back in history, even you would need more clicks. But in all the last months I never had to do it. We barely make changes to the marionette_driver package.

I will leave it up to David. If he is also against it, we can update the patch and at least land the wpt-runner change.

	David Burns :automatedtester
	Comment 6 • 7 years ago
mozreview-review

Comment on attachment 8910236 [details]
Bug 1401510 - Rename testing/marionette/client to testing/marionette/driver.

https://reviewboard.mozilla.org/r/181718/#review188476

Since this has already been driver in the past this patch I am against flip flopping the name.

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 7 • 7 years ago

So we will have to live with the confusing name of the subfolder until we are able to get rid of the package in favor of geckodriver only tests.