Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Description • 7 years ago

The last release was 2 months ago and has been done via bug 1366199. If we need a major bump due to API level changes would have to be checked. I simply used the usual minor bumps to file this tracking bug.

Generally we seem to use it regarding the wrong usage of startup_timeout and some tests suites using pypi instead of the in-tree version of Marionette driver.

One bug I would like to wait for at least is bug 1394381 which will add logging to Marionette driver, and would massively help us with investigating test failures.

	James Graham [:jgraham]
	Comment 1 • 7 years ago

I filed and put a patch on bug 1410889. I think the release should be urgent (i.e. not depend on other features) since afaict passing in capabilities with the current release and nightly Firefox is broken.

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 2 • 7 years ago

No-one noticed that so far since the patch on bug 1388424 landed. As such I was not aware of such an urgency. Please note that I want to have the two newly added dependencies also fixed because both are currently causing two of our top intermittent issues. We can definitely leave out the logging feature of the client.

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 4 • 7 years ago

No solution yet for bug 1410883, so we cannot wait for it. I will prepare a release now.

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 5 • 7 years ago

Changes since marionette-driver 2.3.0:

% hg log -M -r c0c5f6c55d3a:: --template "{desc|firstline}\n" .
Bug 1381347 - Use deprecated quitApplication command in Marionette client; r=whimboo
Bug 1378121 - Add WebDriver:MinimizeWindow command to Marionette; r=ato
Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
Bug 1387380 - Stop capabilities negotiation in Marionette. r=whimboo
Bug 1388424 - Fix flake8 issue a=me
Bug 1385484 - Ensure that login reputation checks are disabled in tests. r=hchang
Bug 1388938 - Disable channel annotation and flashblock in tests harnesses.r=hchang
Bug 1394377 - Increase default shutdown timeout to 120s. r=maja_zf
Bug 1395126 - Support cascading configuration for flake8, r=bc
Bug 1397734 - Centralize defaults for socket and startup timeouts r=maja_zf
Bug 1397675 - Immediately kill the process if no connection can be made after startup. r=maja_zf
Bug 1399628 - Disable Shield extension in Marionette and geckodriver. r=ato
Bug 1393366 - Increase the marionette connect timeout in wptrunner, r=maja_zf
Bug 1368034 - Update default values for urlbar searches in Marionette r=whimboo
Bug 1350897 - Tested quit shutdown/restart cause in Marionette Python client. r=whimboo
Bug 1409030 - Remove Marionette socket protocol levels below 3. r=ato
Bug 1406212 - Remove browser.tabs.remote.autostart.N. r=Felipe
Bug 1406212 - Remove references to extensions.e10sBlocksEnabling. r=Felipe
Bug 1410366 - Improve socket handling in wait_for_port r=ato

Changes since marionette-harness 4.1.0:

% hg log -M -r c0c5f6c55d3a:: --template "{desc|firstline}\n" .
Bug 1374762 - Allow Marionette to handle the safe mode dialog. r=ato
Bug 1360687 - Synchronize webextension from Puppeteer with Marionette harness. r=davehunt
Bug 1377876 - Disable 'test_crash.py' when running on linux64-ccov. r=whimboo
Bug 1378191 - Use JSON to send capabilities in "Marionette:listenersAttached" r=automatedtester
Bug 1378239 - Change mozinfo 'coverage' flag to 'ccov' to avoid ambiguity. r=ahal
Bug 1332122 - Add unit tests for navigating to file:// URLs. r=automatedtester
Bug 1374672 - Don't wait for page load events for identical hash parameters. r=automatedtester
Bug 1360446 - Broaden skip of test_click.py TestLegacyClick.test_click for continued intermittent failures; r=whimboo
Bug 1381339 - Re-enable test_navigation.py TestBackForwardNavigation.test_frameset. r=ato
Bug 1360446 - Enable marionette test_click.py, but disable the troublesome TestLegacyClick.test_click part, on e10s; r=whimboo
Bug 1381403 - Wait for minidump files in mozcrash mockup. r=ato
Bug 1368434 - Fix race condition for slow frame script registrations. r=automatedtester
Bug 1368227 - Disabling Marionette navigation eager test on Android. r=jgraham
Bug 1384906 - Use newline in TEST-START and TEST-END log entries; r=automatedtester
Bug 1378121 - Add WebDriver:MinimizeWindow command to Marionette; r=ato
Bug 1355147 - Fix test moving to negative coordinates in headless mac. r=whimboo
Bug 1369923 - Disabling test for high intermittence r=me
Bug 1385873 - <option> should not be deselected in dropdown. r=automatedtester
Bug 1386581 - Imply --headless when MOZ_HEADLESS is set. r=automatedtester
Bug 1373739 - Re-enable chrome-switching tests on headless mode. r=bdahl
Bug 1373739 - Enable Marionette "screenshot" tests in headless. r=bdahl
Bug 1387447 - Update accessibility pointer-events expectations. r=yzen
Bug 1381876 - Fix window maximised assertions. r=automatedtester
Bug 1381876 - Remove unused import from test_window_maximize.py. r=automatedtester
Bug 1381876 - Compare window rect, not window size. r=automatedtester
Bug 1387644 - Return NoSuchElementError when element is not found r=ato
Bug 1387380 - Stop capabilities negotiation in Marionette. r=whimboo
Bug 1386977 - Handle popstate events for page loads. r=automatedtester
Bug 1388424 - Read capabilities off top-level object. r=whimboo
Bug 1388627 - Remove obsolete Wait.until() calls from Window Manager Mixin. r=automatedtester
Bug 1388627 - close_chrome_window always operates in chrome context. r=automatedtester
Bug 1389153 - Skip more shadow DOM tests for Stylo. r=heycam
Bug 1387092 - Add support for proxyType "direct". r=ato
Bug 1391016 - Make sure that proxyType is required and a string. r=automatedtester
Bug 1391016 - "proxyAutoconfigUrl" is required for proxyType "pac". r=automatedtester
Bug 1254136 - Fix double registration for sessionstore-windows-restored. r=automatedtester
Bug 1391691 - Make WebDriver:MinimizeWindow idempotent. r=automatedtester
Bug 1391691 - Make WebDriver:MaximizeWindow idempotent. r=automatedtester
Bug 1391691 - Make WebDriver:FullscreenWindow idempotent. r=automatedtester
Bug 1393094 - Relicense test_execute_script.py to public domain. r=automatedtester
Bug 1393097 - Relicense test_execute_async_script.py to public domain. r=automatedtester
Bug 1390359 - Replace faded out (i) icon with a search icon when the location bar is empty or modified. r=adw
Bug 1387678 - Skip all tests in test_shadow_dom.py due to intermittent failures. r=jmaher
Bug 1395126 - Support cascading configuration for flake8, r=bc
Bug 1369827 - Make proxy port an optional suffix for the host. r=ato
Bug 1369827 - Fix socksVersion key in proxy capabilities. r=ato
Bug 1339178 - Use pytest to run python-tests, r=davehunt
Bug 1387094 - Add noProxy support for manual proxy type. r=ato
Bug 1387470 - Use moz:webdriverClick capability for spec conforming element click. r=ato
Bug 1331313 - Let add-on install() / uninstall() wait for the expected add-on. r=ato
Bug 1397734 - Centralize defaults for socket and startup timeouts r=maja_zf
Bug 1398499: Part 3 - Add Marionette tests for global sharing. r=mccr8
Bug 1399076 - Error when weakref of web element is destroyed. r=automatedtester
Bug 1397675 - Immediately kill the process if no connection can be made after startup. r=maja_zf
Bug 1400594 - Further reduce start_timeout for test_startup_timeout. r=maja_zf
Bug 1389488 - Check that add-on file exists before forwarding request to AddonManager r=whimboo
Bug 1375660 - Remove duplicate button 9 reference in test_accessibility. r=ato
Bug 1399204 - Update test_long_press_to_select_when_partial_visible_word_is_selected(). r=mtseng
Bug 1409030 - Remove Marionette socket protocol levels below 3. r=ato
Bug 1396880 - Skip not relevant checks in test_accessibility for webdriver click. r=ato
Bug 1408508 - Move Context to browser module. r=maja_zf
Bug 1406212 - Remove references to extensions.e10sBlocksEnabling. r=Felipe
Bug 1410355 - Re-enable Marionette unit tests for ASAN builds except crash tests. r=ato
Bug 1410366 - Stop socket server from listening for new connections if told so. r=ato


Going through those lists I can see changes without our approval. Those are the following bugs:

Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
Bug 1385484 - Ensure that login reputation checks are disabled in tests. r=hchang
Bug 1388938 - Disable channel annotation and flashblock in tests harnesses.r=hchang
Bug 1406212 - Remove browser.tabs.remote.autostart.N. r=Felipe
Bug 1406212 - Remove references to extensions.e10sBlocksEnabling. r=Felipe
Bug 1390359 - Replace faded out (i) icon with a search icon when the location bar is empty or modified. r=adw
Bug 1398499: Part 3 - Add Marionette tests for global sharing. r=mccr8

I think that at least the changes from bug 1406212 should block the release and we have to get this reverted.

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 6 • 7 years ago

(In reply to Henrik Skupin (:whimboo) from comment #5)
> Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj

Not a problem for us given that the move from nsILocalFile to nsIFile happened a long time ago.

> Bug 1385484 - Ensure that login reputation checks are disabled in tests.
> r=hchang
> Bug 1388938 - Disable channel annotation and flashblock in tests
> harnesses.r=hchang

There is only one preference which got removed here, which does no longer exist since Firefox 50 (bug 1025965).

> Bug 1406212 - Remove browser.tabs.remote.autostart.N. r=Felipe
> Bug 1406212 - Remove references to extensions.e10sBlocksEnabling. r=Felipe

Looks like I was wrong here. Preferences removed are:

* browser.tabs.remote.autostart.* - which is fine given that we don't use them to enable/disable e10s
* extensions.e10sBlocksEnabling - we forced a user value of false. As such we turned it off, and so it should not harm us

> Bug 1390359 - Replace faded out (i) icon with a search icon when the
> location bar is empty or modified. r=adw

Only a change of the test.

> Bug 1398499: Part 3 - Add Marionette tests for global sharing. r=mccr8

With this bug only a test got added.

So I think we are good for doing a release now.

	Andreas Tolfsen ❲:ato❳
	Comment 8 • 7 years ago
mozreview-review

Comment on attachment 8921880 [details]
Bug 1401498 - Release marionette-driver 2.4.0 and marionette-harness 4.2.0.

https://reviewboard.mozilla.org/r/192922/#review198146

	Pulsebot
	Comment 9 • 7 years ago

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24906afd73a2
Release marionette-driver 2.4.0 and marionette-harness 4.2.0. r=ato

	Attila Craciun [:arny]
	Comment 10 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/24906afd73a2

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 11 • 7 years ago

Uploaded both packages to PyPI:

marionette_driver:
------------------
Uploading distributions to https://upload.pypi.org/legacy/
Uploading marionette_driver-2.4.0-py2-none-any.whl
Uploading marionette_driver-2.4.0.tar.gz

marionette_harness:
-------------------
Uploading distributions to https://upload.pypi.org/legacy/
Uploading marionette_harness-4.2.0-py2-none-any.whl
Uploading marionette-harness-4.2.0.tar.gz