Closed
Bug 1400226
Opened 7 years ago
Closed 7 years ago
Wait for visibilitychange event in WebDriver:MinimizeWindow
Categories
(Remote Protocol :: Marionette, defect, P1)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(1 file)
4.15 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
The sizemodechange event is not strongly connected to the visibilitychange event that the WPT minimize_window.py test is now using to ascertain whether the window has been successfully iconified. Because Marionette uses the sizemodechange event it is causing intermittents such as https://bugzil.la/1397007. You can also read a lengthy summary I did on the problem in https://bugzil.la/1397007#c11. The fix for the problem is to wait for the visibilitychange DOM event content.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P1
Assignee | ||
Comment 1•7 years ago
|
||
The sizemodechange event is not strongly connected to the visibilitychange event that the WPT minimize_window.py test is now using to ascertain whether the window has been successfully iconified. Because Marionette uses the sizemodechange event it is causing intermittents such as https://bugzil.la/1397007. You can also read a lengthy summary I did on the problem in https://bugzil.la/1397007#c11. The fix for the problem is to wait for the visibilitychange DOM event content. MozReview-Commit-ID: B6i33Ee5iMC
Assignee | ||
Updated•7 years ago
|
Attachment #8910282 -
Flags: review?(hskupin)
Assignee | ||
Comment 2•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f83a6d597a90fd32006e3d0370b675944c27ee3f
Comment 3•7 years ago
|
||
Comment on attachment 8910282 [details] [diff] [review] Wait for visibilitychange event on window minimize/restore. r?whimboo Review of attachment 8910282 [details] [diff] [review]: ----------------------------------------------------------------- A mozreview request would be nicer, maybe you plan one now that the dependency has been fixed. Until then a question I would like see answered first. Thanks. ::: testing/marionette/driver.js @@ +3720,2 @@ > */ > +async function restoreWindow(chromeWindow, contentWindow) { Why can't we add this method to the BrowserContext class, which has both the information for chrome and content window available, and IMO would be a better fit for this feature.
Attachment #8910282 -
Flags: review?(hskupin)
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #3) > ::: testing/marionette/driver.js > @@ +3720,2 @@ > > */ > > +async function restoreWindow(chromeWindow, contentWindow) { > > Why can't we add this method to the BrowserContext class, which > has both the information for chrome and content window available, > and IMO would be a better fit for this feature. This will get moved to a class similar in nature to browser.Context with http://bugzil.la/marionette-window-tracking, but considering none of the other window manipulation helpers are there, it makes sense to leave it in its current place for now.
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8910282 [details] [diff] [review] Wait for visibilitychange event on window minimize/restore. r?whimboo Can we get this patch landed soon so that we can resolve https://bugzil.la/1397007?
Attachment #8910282 -
Flags: review?(hskupin)
Updated•7 years ago
|
Attachment #8910282 -
Flags: review?(hskupin) → review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6470a12114de Wait for visibilitychange event on window minimize/restore. r=whimboo
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6470a12114de
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•