Closed
Bug 1399767
Opened 8 years ago
Closed 8 years ago
Remove preference "layout.css.clip-path-shapes.enabled"
Categories
(Core :: Layout, enhancement, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
<basic-shape> for clip-path had been shipped in Firefox 54 (bug 1247229). It's been a while, so let's remove the preference "layout.css.clip-path-shapes.enabled".
|
||
Updated•8 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → tlin
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8908499 [details]
Bug 1399767 - Remove preference "layout.css.clip-path-shapes.enabled".
https://reviewboard.mozilla.org/r/180162/#review185800
::: layout/style/test/property_database.js:4585
(Diff revision 1)
> type: CSS_TYPE_LONGHAND,
> initial_values: [ "none" ],
> - other_values: [ "url(#mypath)", "url('404.svg#mypath')" ],
> - invalid_values: []
> + other_values: [
> + "url(#mypath)", "url('404.svg#mypath')", "url(#my-clip-path)"
> + ].concat(basicShapeSVGBoxValues).concat(basicShapeOtherValues),
> + invalid_values: [basicShapeInvalidValues],
Should this be
invalid_values: basicShapeInvalidValues,
instead?
Attachment #8908499 -
Flags: review?(cam) → review+
|
|
||
Updated•8 years ago
|
Keywords: dev-doc-needed
|
|
Assignee | |
Comment 3•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8908499 [details]
Bug 1399767 - Remove preference "layout.css.clip-path-shapes.enabled".
https://reviewboard.mozilla.org/r/180162/#review185800
> Should this be
>
> invalid_values: basicShapeInvalidValues,
>
> instead?
Right, I'll remove `[]` around `basicShapeInvalidValues`. Thanks for catching this.
| Comment hidden (mozreview-request) |
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Comment 6•8 years ago
|
||
I've documented this by just adding a note to the Fx57 rel notes. I didn't think it was worth mentioning in the main docs.
https://developer.mozilla.org/en-US/Firefox/Releases/57#CSS
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•