Ting-Yu Lin [:TYLin] (PDT, UTC-7) Assignee
	Description • 7 years ago

<basic-shape> for clip-path had been shipped in Firefox 54 (bug 1247229). It's been a while, so let's remove the preference "layout.css.clip-path-shapes.enabled".

	Cameron McCormack (:heycam)
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8908499 [details]
Bug 1399767 - Remove preference "layout.css.clip-path-shapes.enabled".

https://reviewboard.mozilla.org/r/180162/#review185800

::: layout/style/test/property_database.js:4585
(Diff revision 1)
>      type: CSS_TYPE_LONGHAND,
>      initial_values: [ "none" ],
> -    other_values: [ "url(#mypath)", "url('404.svg#mypath')" ],
> -    invalid_values: []
> +    other_values: [
> +      "url(#mypath)", "url('404.svg#mypath')", "url(#my-clip-path)"
> +    ].concat(basicShapeSVGBoxValues).concat(basicShapeOtherValues),
> +    invalid_values: [basicShapeInvalidValues],

Should this be

  invalid_values: basicShapeInvalidValues,

instead?

	Ting-Yu Lin [:TYLin] (PDT, UTC-7) Assignee
	Comment 3 • 7 years ago
mozreview-review-reply

Comment on attachment 8908499 [details]
Bug 1399767 - Remove preference "layout.css.clip-path-shapes.enabled".

https://reviewboard.mozilla.org/r/180162/#review185800

> Should this be
> 
>   invalid_values: basicShapeInvalidValues,
> 
> instead?

Right, I'll remove `[]` around `basicShapeInvalidValues`. Thanks for catching this.

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 5 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c452e8622329

	Chris Mills [:cmills]
	Comment 6 • 7 years ago

I've documented this by just adding a note to the Fx57 rel notes. I didn't think it was worth mentioning in the main docs.

https://developer.mozilla.org/en-US/Firefox/Releases/57#CSS