Treeherder Bug Filer Reporter
	Description • 7 years ago
treeherder

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=129237111&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/KP6ZV060TAC5hCNAvgbtug/runs/0/artifacts/public/logs/live_backing.log

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 1 • 7 years ago

This is an unexpected pass:

task 2017-09-07T13:56:32.625434Z] 13:56:32     INFO - TEST-PASS | /webdriver/tests/minimize_window.py | minimize_window.py::test_minimize 
[task 2017-09-07T13:56:32.625648Z] 13:56:32     INFO - TEST-UNEXPECTED-PASS | /webdriver/tests/minimize_window.py | minimize_window.py::test_payload - expected FAIL
[task 2017-09-07T13:56:32.625827Z] 13:56:32     INFO - TEST-INFO | expected FAIL

Andreas, you modified the test a bit lately. Maybe a removal of a line of code from this test makes it (partially) passing now?

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 3 • 7 years ago

(In reply to Henrik Skupin (:whimboo) from comment #1)

> Andreas, you modified the test a bit lately. Maybe a removal of a
> line of code from this test makes it (partially) passing now?

Incidentally I am updating the metadata in
https://bugzil.la/1396866, which should fix this.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 7 • 7 years ago

(In reply to Andreas Tolfsen ‹:ato› from comment #3)

> (In reply to Henrik Skupin (:whimboo) from comment #1)
>
> > Andreas, you modified the test a bit lately. Maybe a removal of
> > a line of code from this test makes it (partially) passing now?
>
> Incidentally I am updating the metadata in
> https://bugzil.la/1396866, which should fix this.

That review appears to be taking a while so submitting a fix for
this separately.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 9 • 7 years ago
mozreview-review

Comment on attachment 8907040 [details]
Bug 1397780 - Enable minimize_window.py::test_payload on debug.

https://reviewboard.mozilla.org/r/178760/#review183866

	Mozilla Autoland
	Comment 10 • 7 years ago

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 66345ad41eac -d 4a0a1836410d: rebasing 419454:66345ad41eac "Bug 1397780 - Enable minimize_window.py::test_payload on debug. r=whimboo" (tip)
local [dest] changed testing/web-platform/meta/webdriver/tests/minimize_window.py.ini which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
unresolved conflicts (see hg resolve, then hg rebase --continue)

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 11 • 7 years ago

Just a note for the keenly interested: This reverses the
relationship between failed and unexpected-failed.  At this point
in time, this test is failing less frequently than it used to so it
makes sense to reverse the relationship.

I am addressing the underlying instability of the
WebDriver:MinimizeWindow command in a follow-up to
https://bugzil.la/1397007.  A lengthy summary of the problem can be
found in https://bugzil.la/1397007#c11.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 14 • 7 years ago

Patches for https://bugzil.la/1396866 landed first, rendering this
patch unnecessary.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 15 • 7 years ago

This bug itself is not invalid, because the failure is/was present. So you are saying that this bug is fixed by the patch on bug 1396866?

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 16 • 7 years ago

(In reply to Henrik Skupin (:whimboo) from comment #15)

> This bug itself is not invalid, because the failure is/was
> present. So you are saying that this bug is fixed by the patch on
> bug 1396866?

No, I’m saying the relationship is reversed: it’s no longer
unexpectedly passing, but failing, something which is tracked by
https://bugzil.la/1397007.

I pointed this out in comment #11.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 19 • 7 years ago

No more failures since Sep 14th.

	BMO Automation
	Comment 20 • 1 year ago

Moving bug to Remote Protocol::Marionette component per bug 1815831.