Closed Bug 1397560 Opened 7 years ago Closed 5 years ago

insane parent process memory use after debugger search

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(firefox57 affected)

RESOLVED FIXED
Tracking Status
firefox57 --- affected

People

(Reporter: bkelly, Unassigned)

Details

(Whiteboard: [MemShrink:P2])

Something bad is happening in my parent process.  I can't safe a memory report, so here is a cut/paste of the main parent part.

2,608.85 MB (100.0%) -- explicit
├──1,921.48 MB (73.65%) ── heap-unclassified
├────393.86 MB (15.10%) -- window-objects
│    ├──306.19 MB (11.74%) -- top(none)/detached
│    │  ├──304.04 MB (11.65%) -- window(chrome://devtools/content/debugger/new/index.html)
│    │  │  ├──284.25 MB (10.90%) -- js-compartment([System Principal], about:blank)
│    │  │  │  ├──283.97 MB (10.88%) -- classes
│    │  │  │  │  ├──270.77 MB (10.38%) -- class(Object)/objects
│    │  │  │  │  │  ├──180.48 MB (06.92%) -- malloc-heap
│    │  │  │  │  │  │  ├──180.48 MB (06.92%) ── slots
│    │  │  │  │  │  │  └────0.00 MB (00.00%) ── elements/normal
│    │  │  │  │  │  └───90.29 MB (03.46%) ── gc-heap
│    │  │  │  │  └───13.20 MB (00.51%) ++ (8 tiny)
│    │  │  │  └────0.29 MB (00.01%) ++ (6 tiny)
│    │  │  └───19.79 MB (00.76%) ++ (3 tiny)
│    │  └────2.14 MB (00.08%) ++ (4 tiny)
│    ├───69.24 MB (02.65%) -- top(chrome://browser/content/browser.xul, id=63)
│    │   ├──59.27 MB (02.27%) -- js-zone(0x2c2f8e25000)
│    │   │  ├──53.93 MB (02.07%) ++ strings
│    │   │  └───5.34 MB (00.20%) ++ (12 tiny)
│    │   └───9.97 MB (00.38%) ++ active
│    └───18.44 MB (00.71%) ++ (22 tiny)
├────152.64 MB (05.85%) -- js-non-window
│    ├──115.20 MB (04.42%) -- zones
│    │  ├───94.43 MB (03.62%) -- zone(0x2c2ea62a000)
│    │  │   ├──59.97 MB (02.30%) ++ (367 tiny)
│    │  │   └──34.46 MB (01.32%) ++ strings
│    │  └───20.77 MB (00.80%) ++ (4 tiny)
│    ├───32.62 MB (01.25%) ++ runtime
│    └────4.81 MB (00.18%) ++ gc-heap
├─────92.32 MB (03.54%) ++ (26 tiny)
└─────48.55 MB (01.86%) -- heap-overhead
      ├──26.96 MB (01.03%) ── bin-unused
      └──21.60 MB (00.83%) ++ (2 tiny)

While typing this bug my memory report page automatically refreshed with this further information.  I guess the memory reporter was extremely slow to return:

3,239.84 MB (100.0%) -- explicit
├──1,654.05 MB (51.05%) -- workers/workers(chrome)/worker(resource://devtools/client/debugger/new/parser-worker.js, 0x2c29693f000)
│  ├──1,629.05 MB (50.28%) -- zone(0x2c2903fa000)
│  │  ├──1,338.35 MB (41.31%) -- compartment(web-worker)
│  │  │  ├──1,337.99 MB (41.30%) -- classes
│  │  │  │  ├──1,053.44 MB (32.52%) -- class(Object)/objects
│  │  │  │  │  ├────965.56 MB (29.80%) ── gc-heap
│  │  │  │  │  └─────87.88 MB (02.71%) -- malloc-heap
│  │  │  │  │        ├──87.88 MB (02.71%) ── slots
│  │  │  │  │        └───0.01 MB (00.00%) ── elements/normal
│  │  │  │  ├────282.12 MB (08.71%) -- class(Array)/objects
│  │  │  │  │    ├──255.32 MB (07.88%) ── gc-heap
│  │  │  │  │    └───26.81 MB (00.83%) ++ malloc-heap
│  │  │  │  └──────2.42 MB (00.07%) ++ (4 tiny)
│  │  │  └──────0.36 MB (00.01%) ++ (4 tiny)
│  │  ├────192.00 MB (05.93%) ── unique-id-map
│  │  ├─────49.39 MB (01.52%) ++ (9 tiny)
│  │  └─────49.31 MB (01.52%) ++ strings
│  └─────25.00 MB (00.77%) ++ (3 tiny)
└──1,585.79 MB (48.95%) ── heap-unclassified

Just before I started noticing problems I was trying to do devtools debugger find-in-files on messenger.com (logged in) and forum.ionicframeworker.com (logged in).  I'm going to take a wild guess this is a debugger problem.
Jason, any ideas here?  This is a very bad UX.  My browser is janking very badly.  Should we at least limit the size of files we search or something?  It seems the parser-worker went a bit out of control here.
Component: General → Developer Tools: Debugger
Flags: needinfo?(jlaster)
Product: Core → Firefox
Summary: insane parent process memory use → insane parent process memory use after debugger search
Hey :bkelly, yulia found a nearly infinite loop on Tuesday with file search. We're fixing it in the next release, which is currently being reviewed now. 

I'll let you know when it lands so we can see if the problem is still there
Flags: needinfo?(jlaster)
Jason can you link to where you're fixing this and give us details on how to confirm it's fixed?
Flags: needinfo?(jlaster)
Whiteboard: [MemShrink] → [MemShrink:P2]
Product: Firefox → DevTools
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.