Henrik Skupin [:whimboo][⌚️UTC+1] Reporter
	Description • 7 years ago

Since geckodriver landed in-tree and we build it via Taskcluster on various platforms the integrated Rust unit tests are no longer executed. I just noticed that myself by running `cargo test` locally.

Andreas, looks like we missed to add the execution of those beside just building geckodriver.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 1 • 7 years ago

We didn’t miss it.  It needs to be done.

	Henrik Skupin [:whimboo][⌚️UTC+1] Reporter
	Comment 2 • 7 years ago

I see. So this should now apply to both geckodriver and webdriver-rust.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 3 • 6 years ago

I’m going to split the work of getting the webdriver crate Rust
tests running out to a separate bug because it is a problem to mach
that it is not a separately vendored crate in m-c.  I’ve filed bug
https://bugzil.la/1424369 about this.

	Ralph Giles (:rillian)
	Comment 6 • 6 years ago
mozreview-review

Comment on attachment 8935891 [details]
Bug 1395933 - Run geckodriver tests in automation.

https://reviewboard.mozilla.org/r/206760/#review212574

r=me assuming it passes tests.

	Ralph Giles (:rillian)
	Comment 7 • 6 years ago
mozreview-review

Comment on attachment 8935892 [details]
Bug 1395933 - Expand geckodriver mach command with test and build targets.

https://reviewboard.mozilla.org/r/206762/#review212580

::: testing/geckodriver/CONTRIBUTING.md:157
(Diff revision 1)
>  a set of conformance tests with other browser vendors through the
>  [Web Platform Tests] (WPT) initiative.  This lets us ensure web
>  compatibility between _different_ WebDriver implementations for
>  different browsers.
>  
> -In addition to the WPT tests, geckodriver and libwebdriver has
> +In addition to the WPT tests, geckodriver and webdriver has unit tests.

`geckodriver and webdriver *have* unit tests` for correct number agreement.

::: testing/geckodriver/CONTRIBUTING.md:162
(Diff revision 1)
> -you need to kick off a separate build using [cargo]:
>  
> -	% cd testing/geckodriver
> +	% ./mach geckodriver test
> -	   Compiling geckodriver v0.19.0 (file:///home/ato/src/gecko/testing/geckodriver)
>  	…
> -	test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
> +	 0:02.39 test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Did you mean to add the runtime to the documented output here?

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 10 • 6 years ago

rillian: Thanks for all your useful input.  I’ve addressed your
concerns about testing/geckodriver/CONTRIBUTING.md.

There are some compile failures with winapi on windows2012, but
rebased and triggered a new try build to make sure they are real.

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 11 • 6 years ago
mozreview-review

Comment on attachment 8935892 [details]
Bug 1395933 - Expand geckodriver mach command with test and build targets.

https://reviewboard.mozilla.org/r/206762/#review213036

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 12 • 6 years ago

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=35d8193e484ceb6f995469c8d4258a535e97ba7a

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 13 • 6 years ago

The instability of the Windows jobs seems to an unrelated issue to
the changes I am making in this changeset.  There is a intermittent
filed in https://bugzilla.mozilla.org/show_bug.cgi?id=1420472.

	Pulsebot
	Comment 14 • 6 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7827a7002f94
Run geckodriver tests in automation. r=rillian
https://hg.mozilla.org/integration/autoland/rev/81228d9e87e5
Expand geckodriver mach command with test and build targets. r=maja_zf,rillian

	Cosmin Sabou [:CosminS]
	Comment 18 • 6 years ago

Backed out for build bustages on js/src/jit-test/tests/typedobject/bug-1415313.js 

https://treeherder.mozilla.org/logviewer.html#?job_id=151467469&repo=autoland&lineNumber=326

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=81228d9e87e5a110ed42580e73c65c0f5fabefc1&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

https://hg.mozilla.org/integration/autoland/rev/5b4ca3085e743cb2c45309b652f96f5741033f82

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 20 • 6 years ago

I forgot to update the patches that were on mozreview.  The problems
had been fixed in my local branch.

New try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7a06fa1f65c49e769b619574abc910ea4613511

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 21 • 6 years ago

Even newer try run without artifact builds:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18199899918112e3d72c2de8f66390f8b6bc2501

	Pulsebot
	Comment 22 • 6 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c394ade418a
Run geckodriver tests in automation. r=rillian
https://hg.mozilla.org/integration/autoland/rev/dfba797e7a1f
Expand geckodriver mach command with test and build targets. r=maja_zf,rillian

	Dorel Luca [:dluca]
	Comment 23 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/7c394ade418a
https://hg.mozilla.org/mozilla-central/rev/dfba797e7a1f