Treeherder Bug Filer Reporter
	Description • 7 years ago
treeherder

Filed by: hskupin [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=127302159&repo=autoland

https://queue.taskcluster.net/v1/task/UXc_E2snTfea9TkGNoQfmw/runs/0/artifacts/public/logs/live_backing.log

The signature of the test failure as reported on bug 1392854 has been changed since the patch on bug 
1394881 landed.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 1 • 7 years ago

Andreas, please have a look. The issues are still not fixed.

Here is how it looks now:

[task 2017-08-31T06:10:36.510759Z] 06:10:36     INFO - TEST-UNEXPECTED-ERROR | test_submit_unencrypted_info_warning.py TestSubmitUnencryptedInfoWarning.test_submit_unencrypted_info_warning | UnknownException: TypeError: win is null
[task 2017-08-31T06:10:36.511638Z] 06:10:36     INFO - stacktrace:
[task 2017-08-31T06:10:36.512463Z] 06:10:36     INFO - 	element.isStale@chrome://marionette/content/element.js:639:7
[task 2017-08-31T06:10:36.513423Z] 06:10:36     INFO - 	get@chrome://marionette/content/element.js:181:9
[task 2017-08-31T06:10:36.514317Z] 06:10:36     INFO - 	isElementEnabled@chrome://marionette/content/listener.js:1484:12
[task 2017-08-31T06:10:36.515168Z] 06:10:36     INFO - 	dispatch/</req<@chrome://marionette/content/listener.js:515:16
[task 2017-08-31T06:10:36.516005Z] 06:10:36     INFO - 	async*dispatch/<@chrome://marionette/content/listener.js:513:16

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 2 • 7 years ago

I would like to see a specific Marionette unit test which covers this scenario.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 3 • 7 years ago

A permanent failure is an improvement, we’re making progress on
the matter here.

I suspect that XUL elements’ owner global is not a transparent
proxy in the same way that an HTML element’s WindowProxy is.  That
is, when a ChromeWindow disappears, a XUL elements’ owner global
will be reset to null, whereas an HTML element’s will always be a
WindowProxy pointing to the current browsing context’s Window.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 4 • 7 years ago

HTML elements' ownerGlobal is a WindowProxy that indirects operations
to the current browsing context.  However, for XUL elements this global
is ChromeWindow which gets reset to null when the window is discarded.

For the same reason, since win indirects to the current browsing context's
associated window, we need to test that the element's node document is
not the active document.

Finally test that its shadow-including root is a document.

MozReview-Commit-ID: EYh18P8DbcN

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 5 • 7 years ago

Comment on attachment 8903131 [details] [diff] [review]
Check discarded ChromeWindow in staleness test. r?automatedtester

https://bugzil.la/1394881 has not landed on m-c yet so mozreview
prevents me from submitting a patch there.  This will apply on top
of m-c once the dependent patch lands, and I’ve confirmed locally
that it fixes the Firefox UI test fallout.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 6 • 7 years ago

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=67be14d2d7a42af404b372071ae866fc857e0795

	Pulsebot
	Comment 7 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2124b88c59d
Check discarded ChromeWindow in staleness test. r=me

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 8 • 7 years ago

I landed this as r=me and will do a rare request for a
post-integration review because the sheriffs were concerned with
leaving this perma-fail in the tree over the weekend.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 10 • 7 years ago

(In reply to Andreas Tolfsen ‹:ato› from comment #8)
> I landed this as r=me and will do a rare request for a
> post-integration review because the sheriffs were concerned with
> leaving this perma-fail in the tree over the weekend.

Just as a side note... I was around the whole day. Why didn't you just ask me, or Maja, or James? We all could have done that review request. It's not always David who has to review everything.

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 11 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f2124b88c59d

	BMO Automation
	Comment 15 • 1 year ago

Moving bug to Testing::Marionette Client and Harness component per bug 1815831.