Andreas Tolfsen ❲:ato❳ Assignee
	Description • 7 years ago

A fallout from https://bugzilla.mozilla.org/show_bug.cgi?id=1392346
was https://bugzilla.mozilla.org/show_bug.cgi?id=1392854, which
shows that element.isDisconnected is being called with the wrong
arguments.

Since we in the long term want to get rid of the concept
of window/shadow root containers (in preparation for
https://bugzilla.mozilla.org/show_bug.cgi?id=marionette-window-track
ing), we might as well fix the fallout by making
element.isDisconnected take separate window- and shadowRoot
arguments.

	David Burns :automatedtester
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8901233 [details]
Bug 1393812 - Fix call to element.isDisconnected.

https://reviewboard.mozilla.org/r/172700/#review179234

	Pulsebot
	Comment 3 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/198a67266e20
Fix call to element.isDisconnected. r=automatedtester

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 4 • 7 years ago

Andreas, this patch doesn't fix the problems we have reported as bug 1311041, and 1392854. Please note that your try build doesn't include any of the Firefox UI tests. So how should we proceed now?

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 5 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/198a67266e20

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 6 • 7 years ago

(In reply to Henrik Skupin (:whimboo) from comment #4)

> Andreas, this patch doesn't fix the problems we have reported as
> bug 1311041, and 1392854. Please note that your try build doesn't
> include any of the Firefox UI tests. So how should we proceed now?

I’m a little surprised by that, but the test logs you linked me in
https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=Firefox%20UI&bugfiler&fromchange=1a1f4fe397d9c41e71b44645c85399ae0726bfd1&selectedJob=127059994
show a slightly different stacktrace.  There seems to be
an intermittency issue to do with the availability of the
Node.compareDocumentPosition web API?

In any case https://bugzilla.mozilla.org/show_bug.cgi?id=1394881,
which removes the use of this API altogether, should fix this.