Andreas Tolfsen ❲:ato❳ Assignee
	Description • 7 years ago

JavaScript code in testing/marionette predominantly uses camel-case
for properties and variable names.  To ensure consistency in this,
we should add an eslint rule for it.

There are some exceptions where we use snake case for output sent
across the wire.  We can disable the lint rule on an individual
basis for these cases.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8899122 [details]
Bug 1391952 - Introduce camel case lint rule.

https://reviewboard.mozilla.org/r/170428/#review175770

::: commit-message-4f448:9
(Diff revision 1)
> +camel casing in naming properties and variables.  To enforce consistency
> +with this practice, this patch adds an eslint rule to enforce camel case.
> +
> +There are a few exceptions where we use snake case in response output.
> +We can disable the lint rule on an individual basis in this handful
> +of cases.

Please put this changeset last in this series to not cause lint failures.

	David Burns :automatedtester
	Comment 5 • 7 years ago
mozreview-review

Comment on attachment 8899123 [details]
Bug 1391952 - Disable camel case lint for input and output.

https://reviewboard.mozilla.org/r/170430/#review175812

	David Burns :automatedtester
	Comment 6 • 7 years ago
mozreview-review

Comment on attachment 8899124 [details]
Bug 1391952 - Lint testing/marionette.

https://reviewboard.mozilla.org/r/170432/#review175816

	David Burns :automatedtester
	Comment 7 • 7 years ago
mozreview-review

Comment on attachment 8899122 [details]
Bug 1391952 - Introduce camel case lint rule.

https://reviewboard.mozilla.org/r/170428/#review175818

	Pulsebot
	Comment 11 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83654c55045b
Lint testing/marionette. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/213d621c2126
Disable camel case lint for input and output. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/e0c0a84e0dfd
Introduce camel case lint rule. r=automatedtester

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 12 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/83654c55045b
https://hg.mozilla.org/mozilla-central/rev/213d621c2126
https://hg.mozilla.org/mozilla-central/rev/e0c0a84e0dfd