Andreas Tolfsen ❲:ato❳ Assignee
	Description • 7 years ago

As a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1254136, we want to eslint to catch missing break statements in switches to avoid similar future bugs.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8898922 [details]
Bug 1391699 - Disallow fallthrough case statements.

https://reviewboard.mozilla.org/r/170288/#review175776

::: testing/marionette/.eslintrc.js:16
(Diff revision 1)
>      }],
>      "max-len": ["error", 78, {
>        "ignoreStrings": true,
>        "ignoreUrls": true,
>      }],
> +    "no-fallthrough": "error",

So this only applies when you have at least one line of code for a case? I see a couple of instances when we have fall-throughs but case lines are right after each other.

	David Burns :automatedtester
	Comment 3 • 7 years ago
mozreview-review

Comment on attachment 8898922 [details]
Bug 1391699 - Disallow fallthrough case statements.

https://reviewboard.mozilla.org/r/170288/#review175822

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 4 • 7 years ago

(In reply to Henrik Skupin (:whimboo) from comment #2)

> So this only applies when you have at least one line of code for a
> case? I see a couple of instances when we have fall-throughs but
> case lines are right after each other.

Yes, it assumes this is intentional use of fall through.

	Pulsebot
	Comment 5 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5add563d059
Disallow fallthrough case statements. r=automatedtester

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a5add563d059