Closed
Bug 1388365
Opened 7 years ago
Closed 7 years ago
Upgrade to webdriver 0.29.0
Categories
(Testing :: geckodriver, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(7 files)
59 bytes,
text/x-review-board-request
|
whimboo
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
whimboo
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
whimboo
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
whimboo
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
whimboo
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
whimboo
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
whimboo
:
review+
|
Details |
webdriver 0.29.0 was just released today.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8894895 [details] Bug 1388365 - Upgrade to webdriver 0.29.0. https://reviewboard.mozilla.org/r/166048/#review171226
Attachment #8894895 -
Flags: review?(hskupin) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8894896 [details] Bug 1388365 - Vendor webdriver 0.29.0. https://reviewboard.mozilla.org/r/166050/#review171234
Attachment #8894896 -
Flags: review?(hskupin) → review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8894897 [details] Bug 1388365 - Return window to normal state. https://reviewboard.mozilla.org/r/166052/#review171250 ::: testing/web-platform/tests/webdriver/tests/support/fixtures.py:40 (Diff revision 1) > pass > > session.window_handle = current_window > > > +def _return_window_to_normal_state(session): I would call it `restore_normal_window_state`. ::: testing/web-platform/tests/webdriver/tests/support/fixtures.py:156 (Diff revision 1) > > # finalisers are popped off a stack, > # making their ordering reverse > request.addfinalizer(lambda: _switch_to_top_level_browsing_context(_current_session)) > request.addfinalizer(lambda: _restore_windows(_current_session)) > + request.addfinalizer(lambda: _return_window_to_normal_state(_current_session)) Lets make sure we do this AFTER the call to `_restore_windows`, so we restore only the last remaining window. Otherwise we might close the restored window and leave another window maximized.
Attachment #8894897 -
Flags: review?(hskupin) → review-
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8894898 [details] Bug 1388365 - Add client.Window#state and #rect. https://reviewboard.mozilla.org/r/166054/#review171254 ::: commit-message-c123b:4 (Diff revision 1) > +Bug 1388365 - Add client.Window#state and #rect. r?whimboo > + > +Introduces two new APIs on client.Window in the WPT WebDriver client. > +rect, and #rect is used to reduce raw calls to GET window/rect. Hm, what is `rect` in this context?
Attachment #8894898 -
Flags: review?(hskupin) → review+
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8894899 [details] Bug 1388365 - Add minimize and fullscreen to client.Window. https://reviewboard.mozilla.org/r/166056/#review171256
Attachment #8894899 -
Flags: review?(hskupin) → review+
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8894900 [details] Bug 1388365 - Return value from assert_success. https://reviewboard.mozilla.org/r/166058/#review171258 ::: commit-message-9c933:4 (Diff revision 1) > +Bug 1388365 - Return value from assert_success. r?whimboo > + > +Return the contents of value, if it exists, after asserting the response > +was successful. The description here is just the code. Can you please explain why this is necessary? It's not clear to me.
Attachment #8894900 -
Flags: review?(hskupin) → review+
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8894901 [details] Bug 1388365 - Test window rect state. https://reviewboard.mozilla.org/r/166060/#review171262
Attachment #8894901 -
Flags: review?(hskupin) → review+
Assignee | ||
Comment 15•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8894897 [details] Bug 1388365 - Return window to normal state. https://reviewboard.mozilla.org/r/166052/#review171250 > I would call it `restore_normal_window_state`. That is a better name, thanks. > Lets make sure we do this AFTER the call to `_restore_windows`, so we restore only the last remaining window. Otherwise we might close the restored window and leave another window maximized. Yes.
Assignee | ||
Comment 16•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8894900 [details] Bug 1388365 - Return value from assert_success. https://reviewboard.mozilla.org/r/166058/#review171258 > The description here is just the code. Can you please explain why this is necessary? It's not clear to me. assert_success can be passed a value which will assert that the response's value matches an expected value. If you want to compare a subsection of the response it may be convenient to for the value to be returned after it has been asserted that the response was a success. I’ve included this in the commit message.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 22•7 years ago
|
||
mozreview-review |
Comment on attachment 8894897 [details] Bug 1388365 - Return window to normal state. https://reviewboard.mozilla.org/r/166052/#review171588
Attachment #8894897 -
Flags: review?(hskupin) → review+
Comment 23•7 years ago
|
||
Given that Andreas is out the next days I'm going to push this patch series now to unblock myself for proxy related work.
Comment 24•7 years ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/535e76277207 Upgrade to webdriver 0.29.0. r=whimboo https://hg.mozilla.org/integration/autoland/rev/ec1bd26e8184 Vendor webdriver 0.29.0. r=whimboo https://hg.mozilla.org/integration/autoland/rev/65dc7d28c6fc Return window to normal state. r=whimboo https://hg.mozilla.org/integration/autoland/rev/4cecb03e8236 Add client.Window#state and #rect. r=whimboo https://hg.mozilla.org/integration/autoland/rev/54f45fe718c5 Add minimize and fullscreen to client.Window. r=whimboo https://hg.mozilla.org/integration/autoland/rev/4e7e4ae3cac6 Return value from assert_success. r=whimboo https://hg.mozilla.org/integration/autoland/rev/17421285e3a2 Test window rect state. r=whimboo
Comment 25•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/535e76277207 https://hg.mozilla.org/mozilla-central/rev/ec1bd26e8184 https://hg.mozilla.org/mozilla-central/rev/65dc7d28c6fc https://hg.mozilla.org/mozilla-central/rev/4cecb03e8236 https://hg.mozilla.org/mozilla-central/rev/54f45fe718c5 https://hg.mozilla.org/mozilla-central/rev/4e7e4ae3cac6 https://hg.mozilla.org/mozilla-central/rev/17421285e3a2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•