Closed Bug 1388082 Opened 7 years ago Closed 7 years ago

Move Marionette to use async/await

Categories

(Remote Protocol :: Marionette, enhancement)

Product:
Remote Protocol
Component:
Marionette
Version:
Version 3
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(10 files, 2 obsolete files)

Bug 1388082 - Convert execute script methods to async.
59 bytes, text/x-review-board-request
automatedtester
: review+
Details
Bug 1388082 - Switch to async/await in action module.
59 bytes, text/x-review-board-request
automatedtester
: review+
Details
Bug 1388082 - Switch to async/await in interaction module.
59 bytes, text/x-review-board-request
automatedtester
: review+
Details
Bug 1388082 - Update proxy examples and docs.
59 bytes, text/x-review-board-request
automatedtester
: review+
Details
Bug 1388082 - Use async/await in reftest module.
59 bytes, text/x-review-board-request
automatedtester
: review+
Details
Bug 1388082 - Use async/await in wait module xpcshell tests.
59 bytes, text/x-review-board-request
automatedtester
: review+
Details
Bug 1388082 - Convert content script to async/await.
59 bytes, text/x-review-board-request
automatedtester
: review+
Details
Bug 1388082 - Make WebDriver service use async/await.
59 bytes, text/x-review-board-request
automatedtester
: review+
Details
Bug 1388082 - Remove unused import.
59 bytes, text/x-review-board-request
automatedtester
: review+
Details
Bug 1388082 - Drop Task.jsm from Marionette.
59 bytes, text/x-review-board-request
automatedtester
: review+
Details 
Marionette currently uses a mixture of yield/generator functions and async/await.  The former depends on Task.jsm which is known to be slow and not a web standard.  async/await is on the other hand, a web feature.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Attachment #8894584 - Attachment is obsolete: true
Attachment #8894584 - Flags: review?(dburns)
Attachment #8894592 - Attachment is obsolete: true
Attachment #8894592 - Flags: review?(dburns)
Comment on attachment 8894585 [details]
Bug 1388082 - Convert execute script methods to async.

https://reviewboard.mozilla.org/r/165744/#review171366
Attachment #8894585 - Flags: review?(dburns) → review+
Comment on attachment 8894593 [details]
Bug 1388082 - Make WebDriver service use async/await.

https://reviewboard.mozilla.org/r/165760/#review171432
Attachment #8894593 - Flags: review?(dburns) → review+
Comment on attachment 8894595 [details]
Bug 1388082 - Drop Task.jsm from Marionette.

https://reviewboard.mozilla.org/r/165764/#review171434

::: testing/marionette/server.js:543
(Diff revision 3)
> -      let fn = this.driver.commands[cmd.name];
> +    let fn = this.driver.commands[cmd.name];
> -      if (typeof fn == "undefined") {
> +    if (typeof fn == "undefined") {
> -        throw new UnknownCommandError(cmd.name);
> +      throw new UnknownCommandError(cmd.name);
> -      }
> +    }
>  
> -      if (cmd.name !== "newSession") {
> +    if (!["newSession", "WebDriver::NewSession"].includes(cmd.name)) {

Note to self: This should be "WebDriver:NewSession" with one colon.
Comment on attachment 8894586 [details]
Bug 1388082 - Switch to async/await in action module.

https://reviewboard.mozilla.org/r/165746/#review171436
Attachment #8894586 - Flags: review?(dburns) → review+
Comment on attachment 8894587 [details]
Bug 1388082 - Switch to async/await in interaction module.

https://reviewboard.mozilla.org/r/165748/#review171440
Attachment #8894587 - Flags: review?(dburns) → review+
Comment on attachment 8894588 [details]
Bug 1388082 - Update proxy examples and docs.

https://reviewboard.mozilla.org/r/165750/#review171442
Attachment #8894588 - Flags: review?(dburns) → review+
Comment on attachment 8894589 [details]
Bug 1388082 - Use async/await in reftest module.

https://reviewboard.mozilla.org/r/165752/#review171444
Attachment #8894589 - Flags: review?(dburns) → review+
Comment on attachment 8894590 [details]
Bug 1388082 - Use async/await in wait module xpcshell tests.

https://reviewboard.mozilla.org/r/165754/#review171446
Attachment #8894590 - Flags: review?(dburns) → review+
Comment on attachment 8894591 [details]
Bug 1388082 - Convert content script to async/await.

https://reviewboard.mozilla.org/r/165756/#review171448
Attachment #8894591 - Flags: review?(dburns) → review+
Comment on attachment 8894594 [details]
Bug 1388082 - Remove unused import.

https://reviewboard.mozilla.org/r/165762/#review171450
Attachment #8894594 - Flags: review?(dburns) → review+
Comment on attachment 8894595 [details]
Bug 1388082 - Drop Task.jsm from Marionette.

https://reviewboard.mozilla.org/r/165764/#review171454

Other than your note, r+
Attachment #8894595 - Flags: review?(dburns) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba0db2cfc679
Make WebDriver service use async/await. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/46b466f86f2a
Convert execute script methods to async. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/4f5156b37d92
Switch to async/await in action module. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/4544d74567df
Switch to async/await in interaction module. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/9fa9d73af75d
Update proxy examples and docs. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/b72b671481b8
Use async/await in reftest module. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/c3c29d4953f2
Use async/await in wait module xpcshell tests. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/b9152a5f30f0
Convert content script to async/await. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/c8758f5fdb74
Remove unused import. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/5562e47f9bb5
Drop Task.jsm from Marionette. r=automatedtester
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: