Closed Bug 1387644 Opened 7 years ago Closed 7 years ago

Getting element that doesnt exist returns JavaScriptError instead of NoSuchElementError

Categories

(Remote Protocol :: Marionette, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: automatedtester, Assigned: automatedtester)

References

Details

Attachments

(1 file)

We should return the right error type of NoSuchElementError
Comment on attachment 8894014 [details]
Bug 1387644 - Return NoSuchElementError when element is not found

https://reviewboard.mozilla.org/r/165096/#review170468

::: testing/marionette/element.js:164
(Diff revision 1)
>     * @throws {JavaScriptError}
>     *     If the provided reference is unknown.

Update API docs too.
Attachment #8894014 - Flags: review?(ato) → review+
Blocks: 1376625
Pushed by dburns@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7aa15d0d0ad4
Return NoSuchElementError when element is not found r=ato
https://hg.mozilla.org/mozilla-central/rev/7aa15d0d0ad4
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: