Andreas Tolfsen ❲:ato❳ Reporter
	Description • 7 years ago

In order to gather more data before landing
https://bugzilla.mozilla.org/show_bug.cgi?id=1321516, it needs
to be possible to enable the WebDriver conforming Element Click
implementation in Marionette from geckodriver.  Without it, external
consumers running Selenium tests will not be able to run their
existing body of tests against a WebDriver conforming Element Click
implementation.

This bug is to introduce a new extension capability to geckodriver.
This will then pass {specificationLevel: 1} on to Marionette,
which will make it use interaction.webdriverClickElement
instead of interaction.seleniumClickElement in
testing/marionette/interaction.js.

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 1 • 7 years ago

It would be good to have this in the upcoming 0.19 release of geckodriver.

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 4 • 7 years ago

Andreas, I attached two patches which simply make it working. I'm struggling a bit with a better name for the custom capability, so I left it as `moz:specificationLevel` for now. Do you have any nice-sounding proposal of what we could use here? Finally I would prefer a boolean value here.

I think that we can safely get rid of the "specificationLevel" capability given that it has not been used beside our Marionette unit tests. Can you think about something else?

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 5 • 7 years ago

Oh, and do we want to expose this capability in our readme? I doubt so given that it will not exist that long.

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 6 • 7 years ago

(In reply to Henrik Skupin (:whimboo) from comment #4)

> I attached two patches which simply make it working. I'm
> struggling a bit with a better name for the custom capability, so
> I left it as `moz:specificationLevel` for now. Do you have any
> nice-sounding proposal of what we could use here? Finally I would
> prefer a boolean value here.
> 
> I think that we can safely get rid of the "specificationLevel"
> capability given that it has not been used beside our Marionette
> unit tests. Can you think about something else?

We can safely get rid of specificationLevel.  Like you, I don’t
think moz:specificationLevel is great either.  It originates from
a time when it was believed returning the specification level
supported by the implementation was a good idea.  We have since
decided to return the actual capabilities that the driver supports,
e.g. "rotatable".

Maybe moz:webdriverClick would work?  This is a capability that we
want to eventually get rid of anyway, so we should be too fuzzy
about picking any name.

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 9 • 7 years ago
mozreview-review

Comment on attachment 8903628 [details]
Bug 1387470 - Use moz:webdriverClick capability for spec conforming element click.

https://reviewboard.mozilla.org/r/175402/#review181530

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 10 • 7 years ago
mozreview-review

Comment on attachment 8903629 [details]
Bug 1387470 - Allow geckodriver to use the webdriver conforming click.

https://reviewboard.mozilla.org/r/175404/#review181532

	Pulsebot
	Comment 11 • 7 years ago

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f6b800cfeee
Use moz:webdriverClick capability for spec conforming element click. r=ato
https://hg.mozilla.org/integration/autoland/rev/40fa31e34c5d
Allow geckodriver to use the webdriver conforming click. r=ato

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 12 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/8f6b800cfeee
https://hg.mozilla.org/mozilla-central/rev/40fa31e34c5d