Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018 Assignee
	Description • 7 years ago

We have got sign-off from SoftwareVision.
We will turn on hardware encoder as default in 56.

	Jan-Ivar Bruaroey [:jib] (needinfo? me)
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8893265 [details]
Bug 1386974 - set the preference for android hardware encoder to true in default.

https://reviewboard.mozilla.org/r/164306/#review169744

	Jan-Ivar Bruaroey [:jib] (needinfo? me)
	Comment 3 • 7 years ago

I think this is for 57 at this point, right?

	Jan-Ivar Bruaroey [:jib] (needinfo? me)
	Comment 4 • 7 years ago

Or are we planning to land for 56 (having been on in Nightly)?

	Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018 Assignee
	Comment 5 • 7 years ago

We plan to land for 56.

	Pulsebot
	Comment 6 • 7 years ago

Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a3061347739b
set the preference for android hardware encoder to true in default. r=jib

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 7 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a3061347739b

	Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018 Assignee
	Comment 8 • 7 years ago

Comment on attachment 8893265 [details]
Bug 1386974 - set the preference for android hardware encoder to true in default.

Approval Request Comment
[Feature/Bug causing the regression]:Not regression
[User impact if declined]:hardware encoder won't be enabled in 56 as planned. 
[Is this code covered by automated tests?]:yes
[Has the fix been verified in Nightly?]:yes
[Needs manual test from QE? If yes, steps to reproduce]:no, SoftwareVision already performed the manual test. 
[List of other uplifts needed for the feature/fix]:n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: SoftwareVision tested quite a few android devices and the result is positive.
[String changes made/needed]:no

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 9 • 7 years ago

Comment on attachment 8893265 [details]
Bug 1386974 - set the preference for android hardware encoder to true in default.

Planned release of android feature, let's uplift for 56 beta 1.

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/c5ae0367e5f0

	Eric Shepherd [:sheppy]
	Comment 11 • 7 years ago

Added the note that this has been enabled to Firefox 56 for developers.