David Burns :automatedtester Reporter
	Description • 7 years ago

When working on bug 1364389 the `close` command has stopped working and after bisecting it it looks like bug 1376128  is the cause.

To recreate the issue just run the #step 1 in https://reviewboard.mozilla.org/r/139270/diff/5#index_header

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 1 • 7 years ago

Hm, is it allowed to still being able to access the session id after the session has been closed? I don't see how this should cause a NoSuchWindowException but more an InvalidSessionException.

Also maybe you could have a look at which changeset in bug 1376128 actually caused this change for you? There are a lot.

	David Burns :automatedtester Reporter
	Comment 2 • 7 years ago

Unfortunately I dont have time to look through this. The patches don't work on their own so will leave this for Andreas to do when he gets back.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 3 • 7 years ago

The bad commit is
https://searchfox.org/mozilla-central/diff/de001d80b777ff0fcfa823a52e8d49b4981af040/testing/marionette/driver.js#1289.
I assume I removed it because the win variable wasn’t used, but
that also accidentally removed the window test.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 5 • 7 years ago

So how is the close command related to the get window rect method?

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 7 • 7 years ago

(In reply to Henrik Skupin (:whimboo) [partly available 07/10
-07/14] from comment #5)

> So how is the close command related to the get window rect method?

David’s test opens a window, closes it, and then tries to get the
window rect before having switched back to the default browsing
context:

> session.window_handle = create_window()
> session.close()
> result = session.transport.send("GET", "session/%s/window/rect" % session.session_id)
> assert_error(result, "no such window")

This is a test for the the assertion that was accidentally removed.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 8 • 7 years ago
mozreview-review

Comment on attachment 8884647 [details]
Bug 1378227 - Reintroduce window test for Marionette:GetWindowRect;

https://reviewboard.mozilla.org/r/155502/#review161386

Oh, I see. In that case it's indeed the complete solution. Thanks.

	Pulsebot
	Comment 9 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c9d46ca33bd
Reintroduce window test for Marionette:GetWindowRect; r=whimboo

	Carsten Book [:Tomcat]
	Comment 10 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/2c9d46ca33bd