Closed
Bug 1377232
Opened 7 years ago
Closed 7 years ago
Revert code from bug 1361890
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dylan, Assigned: dylan)
Details
Attachments
(2 files)
Bug 1361890 has a regression. Tests begin failing, in particular line 317 of qa/t/test_bug_edit.t. This test hits the back button, and attempts to rebumit the form. It should get a "Suspicious Action" error, but instead it errors that the summary is required. How does bug 1361890 cause this regression?
Assignee | ||
Comment 1•7 years ago
|
||
It's not clear exactly what the problem is -- it isn't the asset manager code. It might be how js concatenation changed. For now we'll use this bug to revert the bad code, and try this again in bug 1361890.
Summary: Diagnose regression with bug 1361890 → Revert code from bug 1361890
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → dylan
Assignee | ||
Comment 2•7 years ago
|
||
This reverts the code from the mentioned bug and also two "fixes" that were applied too. When applied, the task cluster tests pass. I tested with docker run -ti -m 4048M mozillabteam/bmo-ci env GITHUB_BASE_BRANCH=bug-1377232 TEST_SUITE=selenium runtests.sh (although this occasionally fails because of timing issues in the docker container, it eventually worked)
Attachment #8882942 -
Flags: review?(sebastinssanty)
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8882942 [details] [review] PR r+'d by atoll
Attachment #8882942 -
Flags: review?(sebastinssanty) → review+
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 4•7 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•