Andreas Tolfsen ❲:ato❳ Assignee
	Description • 7 years ago

To prepare for future modularisation of the Marionette server (tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1330309) we need to namespace the “WebDriver service” commands with "webdriver:".

Since it will take a long time for these changes to propagate to ESR so they can be used by geckodriver, we need to start preparing this sooner rather than later.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 1 • 7 years ago

If it's just a name change we could still try to uplift to esr52. We do not support esr45 anymore, and as such no update tests are run. With that we should be all fine with the Firefox 59 ESR release, and can remove the fallback code in Firefox 60.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 9 • 7 years ago
mozreview-review

Comment on attachment 8880368 [details]
Bug 1375425 - Namespace WebDriver commands;

https://reviewboard.mozilla.org/r/151740/#review156696

::: testing/marionette/driver.js:3210
(Diff revision 1)
>    "L10n:LocalizeEntity": GeckoDriver.prototype.localizeEntity,
>    "localization:l10n:localizeEntity": GeckoDriver.prototype.localizeEntity,  // deprecated, remove in Firefox 60
>    "L10n:LocalizeProperty": GeckoDriver.prototype.localizeProperty,
>    "localization:10n:localizeProperty": GeckoDriver.prototype.localizeProperty,  // deprecated, remove in Firefox 60
>  
> -  "newSession": GeckoDriver.prototype.newSession,
> +  // WebDriver service

Maybe we can just move all the deprecated commands to their own section? It's way hard to go through this list now.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 16 • 7 years ago
mozreview-review-reply

Comment on attachment 8880368 [details]
Bug 1375425 - Namespace WebDriver commands;

https://reviewboard.mozilla.org/r/151740/#review156696

> Maybe we can just move all the deprecated commands to their own section? It's way hard to go through this list now.

I’m not sure reorganising it will make it easier to read.  I did it
this way because I thought it would make sense for each command and its
deprecated sibling to follow each other.  The diff does end up messy,
but makes sense if you read the new version sequentially by itself.

But maybe it’s easier the way you suggest if you bring the lists up
next to each other in two editor windows.  I’ve run the list through
sort(1), which should be approximately what you want.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 17 • 7 years ago
mozreview-review-reply

Comment on attachment 8880368 [details]
Bug 1375425 - Namespace WebDriver commands;

https://reviewboard.mozilla.org/r/151740/#review156696

> I’m not sure reorganising it will make it easier to read.  I did it
> this way because I thought it would make sense for each command and its
> deprecated sibling to follow each other.  The diff does end up messy,
> but makes sense if you read the new version sequentially by itself.
> 
> But maybe it’s easier the way you suggest if you bring the lists up
> next to each other in two editor windows.  I’ve run the list through
> sort(1), which should be approximately what you want.

That looks great. Thanks.

	David Burns :automatedtester
	Comment 24 • 7 years ago
mozreview-review

Comment on attachment 8880362 [details]
Bug 1375425 - Remove undefined commands;

https://reviewboard.mozilla.org/r/151728/#review156924

	David Burns :automatedtester
	Comment 25 • 7 years ago
mozreview-review

Comment on attachment 8880363 [details]
Bug 1375425 - Remove deprecated commands;

https://reviewboard.mozilla.org/r/151730/#review157168

	David Burns :automatedtester
	Comment 26 • 7 years ago
mozreview-review

Comment on attachment 8880364 [details]
Bug 1375425 - Namespace the Marionette service;

https://reviewboard.mozilla.org/r/151732/#review157174

	David Burns :automatedtester
	Comment 27 • 7 years ago
mozreview-review

Comment on attachment 8880366 [details]
Bug 1375425 - Correct addon service namespace casing;

https://reviewboard.mozilla.org/r/151736/#review157176

	David Burns :automatedtester
	Comment 28 • 7 years ago
mozreview-review

Comment on attachment 8880367 [details]
Bug 1375425 - Correct l10n service namespace;

https://reviewboard.mozilla.org/r/151738/#review157178

	David Burns :automatedtester
	Comment 29 • 7 years ago
mozreview-review

Comment on attachment 8880368 [details]
Bug 1375425 - Namespace WebDriver commands;

https://reviewboard.mozilla.org/r/151740/#review157186

	Pulsebot
	Comment 30 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7aedadb6ba0c
Remove undefined commands; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/e95dd3bdd995
Remove deprecated commands; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/3048dd2cba5a
Namespace the Marionette service; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/822d1b77b12c
Correct addon service namespace casing; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/24eab63c2b77
Correct l10n service namespace; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/1e96a289d28a
Namespace WebDriver commands; r=automatedtester

	Carsten Book [:Tomcat]
	Comment 31 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/7aedadb6ba0c
https://hg.mozilla.org/mozilla-central/rev/e95dd3bdd995
https://hg.mozilla.org/mozilla-central/rev/3048dd2cba5a
https://hg.mozilla.org/mozilla-central/rev/822d1b77b12c
https://hg.mozilla.org/mozilla-central/rev/24eab63c2b77
https://hg.mozilla.org/mozilla-central/rev/1e96a289d28a