Andreas Tolfsen ❲:ato❳ Assignee
	Description • 7 years ago

Now that we don’t have tagging of geckodriver anymore because hg does not really support it, we need to include build information in the --version flag.  An example of useful information would be the SHA1 off of which the current binary was built.

	James Graham [:jgraham]
	Comment 3 • 7 years ago
mozreview-review

Comment on attachment 8880441 [details]
Bug 1375207 - Quench unused import warning for CookieResponse;

https://reviewboard.mozilla.org/r/151794/#review156794

	James Graham [:jgraham]
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8880442 [details]
Bug 1375207 - Display hash from whence geckodriver came in --version;

https://reviewboard.mozilla.org/r/151796/#review156792

::: testing/geckodriver/build.rs:35
(Diff revision 1)
> +        commit_date()
> +    ).unwrap();
> +}
> +
> +fn commit_hash() -> Option<String> {
> +    exec(&"hg", &["log", "-r.", "-T '{node|short}'"])

Any interest in adding

```
.or_else(|| exec(&"git", &["rev-parse", "HEAD"])
            .and_then(|x| exec(&"git", &["cinnabar", "git2hg", x]))
```

and similarly below?

::: testing/geckodriver/src/main.rs:138
(Diff revision 1)
>  
>  fn run() -> ProgramResult {
>      let matches = app().get_matches();
>  
>      if matches.is_present("version") {
> -        println!("geckodriver {}\n\n{}", crate_version!(),
> +        println!("geckodriver {}\n\n{}", BuildInfo,

Wasn't the original request to log the build info to stdout on startup?

	James Graham [:jgraham]
	Comment 5 • 7 years ago
mozreview-review

Comment on attachment 8880442 [details]
Bug 1375207 - Display hash from whence geckodriver came in --version;

https://reviewboard.mozilla.org/r/151796/#review156796

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 6 • 7 years ago
mozreview-review-reply

Comment on attachment 8880442 [details]
Bug 1375207 - Display hash from whence geckodriver came in --version;

https://reviewboard.mozilla.org/r/151796/#review156792

> Any interest in adding
> 
> ```
> .or_else(|| exec(&"git", &["rev-parse", "HEAD"])
>             .and_then(|x| exec(&"git", &["cinnabar", "git2hg", x]))
> ```
> 
> and similarly below?

I didn’t know about "git cinnabar git2hg".  That is an excellent tool!
I’ve added it in in the latest revision.

> Wasn't the original request to log the build info to stdout on startup?

The primary motivation is to be able to identify from where a release
was made now that we don’t have tagging of releases.  davehunt filed
https://bugzilla.mozilla.org/show_bug.cgi?id=1374977 about displaying
the version also in the log, so I’m going to fix that once this
lands.

	Pulsebot
	Comment 9 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d9e437ac052d
Quench unused import warning for CookieResponse; r=jgraham
https://hg.mozilla.org/integration/autoland/rev/32fe813d0a0e
Display hash from whence geckodriver came in --version; r=jgraham

	Carsten Book [:Tomcat]
	Comment 10 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d9e437ac052d
https://hg.mozilla.org/mozilla-central/rev/32fe813d0a0e