Closed Bug 1375200 Opened 7 years ago Closed 5 years ago

[generic-worker] Remove support for reading secrets from AWS worker type definition

Categories

(Taskcluster :: Workers, enhancement)

Product:
Taskcluster
Component:
Workers
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pmoore, Assigned: pmoore)

References

Details

Attachments

(4 files)

GitHub Pull Request for generic-worker
54 bytes, text/x-github-pull-request
jhford
: review+
Details | Review
GitHub Pull Request for generic-worker (part 2)
54 bytes, text/x-github-pull-request
jhford
: review+
Details | Review
GitHub Pull Request for generic-worker (part 3)
54 bytes, text/x-github-pull-request
jhford
: review+
Details | Review
GitHub Pull Request for generic-worker (part 4)
54 bytes, text/x-github-pull-request
jhford
: review+
Details | Review 
Only do this, once the provisioner no longer supports the feature, i.e. when 1375197 is resolved fixed.
QA Contact: pmoore
Work continues in the dependent bugs.
This work does not directly block the worker manager's deployment (bug 1478941), but does block it from being used in production.  Worker Manager will only support generation of taskcluster credentials and will have no facilities for storing secrets directly.
See Also: → 1478941
(In reply to Pete Moore [:pmoore][:pete] from comment #0)
> Only do this, once the provisioner no longer supports the feature, i.e. when
> 1375197 is resolved fixed.

I think this dependency is reversed.  We cannot remove secrets from the provisioner until they are no longer being read by workers.
Blocks: 1375197
No longer depends on: 1375197
Assignee: nobody → pmoore
Status: NEW → ASSIGNED

Still work-in-progress, will assign reviewer(s) as soon as CI is passing and I'm happy all the parts are implemented that are needed.

Adding PR already to provide transparency about the work I'm doing...

Attachment #9041274 - Flags: review?(jhford)
Attachment #9041274 - Flags: review?(jhford) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

I missed a couple of things in the first PR ....

Attachment #9041799 - Flags: review?(jhford)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #9041799 - Flags: review?(jhford) → review+
Component: Generic-Worker → Workers
Attachment #9042598 - Flags: review?(jhford) → review+
Attachment #9042599 - Flags: review?(jhford) → review+

Released in generic-worker v13.0.2.

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: