Dave Hunt [:davehunt] [he/him] ⌚BST Reporter
	Description • 7 years ago

Whilst running tests against Sauce Labs, it became clear that there's no way to determine the version of geckodriver in use. This level of detail could be useful when troubleshooting issues using Selenium as a service. Could we add the version details when starting geckodriver? Sauce Labs do provide an automator.log file, which contains the geckodriver log contents, so we see entries such as:

1498037999220	geckodriver	INFO	Listening on 127.0.0.1:46473
1498037999889	geckodriver::marionette	INFO	Starting browser \\?\D:\Program Files\Firefox 54\firefox.exe with args ["-marionette"]
1498038000363	Marionette	WARN	Deprecated preference marionette.defaultPrefs.enabled detected, please use marionette.enabled
1498038001957	Marionette	INFO	Listening on port 49757

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 1 • 7 years ago

We have dismissed requests to include the geckodriver version in in the
return capabilities before, but there should not be any harm in logging
the version number.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 2 • 7 years ago

I have laid the groundwork for this in
https://bugzilla.mozilla.org/show_bug.cgi?id=1375207.

	James Graham [:jgraham]
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8880855 [details]
Bug 1374977 - Log geckodriver version on startup;

https://reviewboard.mozilla.org/r/152196/#review157260

::: testing/geckodriver/src/main.rs:50
(Diff revision 1)
>  use logging::LogLevel;
>  use marionette::{MarionetteHandler, MarionetteSettings, extension_routes};
>  
>  include!(concat!(env!("OUT_DIR"), "/build-info.rs"));
>  
> +type ProgramResult = std::result::Result<(), (ExitCode, String)>;

Not for this review, but https://crates.io/crates/exitcode exists.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 5 • 7 years ago
mozreview-review-reply

Comment on attachment 8880855 [details]
Bug 1374977 - Log geckodriver version on startup;

https://reviewboard.mozilla.org/r/152196/#review157260

Thanks!

> Not for this review, but https://crates.io/crates/exitcode exists.

Yay for microcrates?

	Pulsebot
	Comment 6 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6eca8198fea5
Log geckodriver version on startup; r=jgraham

	Carsten Book [:Tomcat]
	Comment 7 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/6eca8198fea5