Robert Strong (they/them - no direct email) Assignee
	Description • 7 years ago

These attributes haven't been used for quite some time and instead we rely on mar signing. Also, in bug 1343891 these values will be removed from the xml served to app update.

	Chris AtLee [:catlee]
	Comment 1 • 7 years ago

I don't think TB relies on mar signing.

	Robert Strong (they/them - no direct email) Assignee
	Comment 2 • 7 years ago

I know but it is now going on a couple of years to add it. bug 1189843

	Robert Strong (they/them - no direct email) Assignee
	Comment 3 • 7 years ago

iirc Thunderbird does check he mar signature on Windows since they wanted to take advantage of the maintenance service and this appears to be the case
https://dxr.mozilla.org/comm-central/source/mail/confvars.sh#21

	Robert Strong (they/them - no direct email) Assignee
	Comment 5 • 7 years ago

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=077b32be5d3dad72be5023da9ba049193a279d57

	Robert Strong (they/them - no direct email) Assignee
	Comment 6 • 7 years ago

Henrik, just a heads up though I don't think these changes will affect your tests.

	Robert Strong (they/them - no direct email) Assignee
	Comment 7 • 7 years ago

Comment on attachment 8878129 [details] [diff] [review]
patch rev1

So much easier to update the tests now. :)

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 8 • 7 years ago

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #6)
> Henrik, just a heads up though I don't think these changes will affect your
> tests.

No, those are not in use.

	Pulsebot
	Comment 9 • 7 years ago

Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e886bf1ba8fc
Remove hashFunction and hashValue attributes from nsIUpdatePatch and code related to these attributes. r=mhowell

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 10 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/e886bf1ba8fc