James Graham [:jgraham] Assignee
	Description • 7 years ago

Seems useful.

	Andreas Tolfsen ❲:ato❳
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8877985 [details]
Bug 1373216 - Add mach command for starting geckodriver,

https://reviewboard.mozilla.org/r/149398/#review153948

::: testing/geckodriver/mach_commands.py:20
(Diff revision 1)
> +    @Command('geckodriver', category='post-build',
> +        description='Run the geckodriver WebDriver implementation')

I wonder whether this should be an extension to `./mach run` so you could call `./mach run geckodriver`.  That has parity with `./mach build testing/geckodriver`.

::: testing/geckodriver/mach_commands.py:24
(Diff revision 1)
> +    @CommandArgument('params', nargs='...',
> +        help='Command-line arguments to be passed through to the program.')

I’m a bit ambivalent to this style as I tend to prefer the more “correct” way to end the first program’s arguments by using ‘--’:

    % cargo run -- --arguments --passed --through

But since this is the style used by `./mach run` already, I guess parity with that is more important.

	Pulsebot
	Comment 3 • 7 years ago

Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/c8497caddebb
Add mach command for starting geckodriver, r=ato

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 4 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c8497caddebb