Closed Bug 1372100 Opened 7 years ago Closed 2 years ago

tabs.create should support muted property

Categories

(WebExtensions :: General, enhancement, P5)

enhancement

Tracking

(firefox57 wontfix, firefox100 fixed)

RESOLVED FIXED
100 Branch
Tracking Status
firefox57 --- wontfix
firefox100 --- fixed

People

(Reporter: kernp25, Assigned: kernp25)

Details

(Keywords: dev-doc-complete, feature, Whiteboard: [design-decision-approved][tabs] triaged)

Attachments

(1 file)

The following code should work:
> browser.tabs.create({
>   url:"https://example.org",
>   muted: true
> });
Whiteboard: [design-decision-needed, tab] triaged
Severity: normal → enhancement
Keywords: feature
Priority: -- → P5
Whiteboard: [design-decision-needed, tab] triaged → [design-decision-needed][tabs] triaged
Hi kernp25, this has been added to the agenda for the October 31 WebExtensions APIs triage meeting. Would you be able to join us? 

Here's a few things about the triage to keep in mind: 

* We normally spend 5 minutes per bug
* The more information in the bug, the better
* The goal of the triage is to give a general thumbs up or thumbs down on a proposal; we won't be going deep into implementation details

Relevant Links: 

* Wiki for the meeting: https://wiki.mozilla.org/Add-ons/Contribute/Triage
* Meeting agenda: https://docs.google.com/document/d/1qqE6fkqr-RNWaFvMpv0Z8O5FLDgQ3AT5eGdbTt7lRGg/edit#
* Vision doc for WebExtensions: https://wiki.mozilla.org/WebExtensions/Vision
Otherwise, we have to write it like so:
browser.tabs.create({url: "https://example.org"}).then(tab => {
 browser.tabs.update(tab.id, {
   muted: true
 });
});

It would be better, if we can just write it like so:
browser.tabs.create({
  url: "https://example.org",
  muted: true
});
Flags: needinfo?(amckay)
Seemed like a good idea to everyone in the meeting. No objections.
Flags: needinfo?(amckay)
Whiteboard: [design-decision-needed][tabs] triaged → [design-decision-approved][tabs] triaged
Maybe this is a "good-first-bug"?
So new contributers can work on this bug?
Flags: needinfo?(amckay)
Hi kernp25, I can bring this up at our good first bugs triage on Wednesday, March 7 to see if it's a good first bug. :)

Other contributors are familiar with the WebExtensions APIs code are very welcome to work on this. We'd be happy to help answer any questions that come up.
Flags: needinfo?(amckay) → needinfo?(cneiman)
Hi kernp25, unfortunately this does not appear to be a good candidate for a 'good-first-bug.' We are not sure if muting a tab just after creating it will stick, and we are hesitate to point new contributors to bugs where we aren't confident of the solution. :( 

However, we won't know if this is possible until someone gives it a try, so contributors are certainly welcome to pick this up! If anyone is interested in landing this, please go ahead and assign yourself to the bug and let us know. We will do our best to provide mentorship. 

Some rudimentary documentation for building WebExtensions APIs is available here: https://webextensions-experiments.readthedocs.io/en/latest/
Flags: needinfo?(cneiman)
Product: Toolkit → WebExtensions
Assignee: nobody → kernp25
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Severity: normal → --
Summary: tabs.create should support muted propertie → tabs.create should support muted property
Severity: -- → N/A
Attachment #9267079 - Attachment description: Bug 1372100 - Support muted in tabs.create. r?robwu → Bug 1372100 - Support muted in tabs.create. r?mixedpuppy
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf5851557406
Support muted in tabs.create. r=mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: