Dão Gottwald [:dao] Reporter
	Description • 7 years ago

[Tracking Requested - why for this release]: recent regression affecting primary UI

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 1 • 7 years ago

Tracked for 55. If we can get a fix landed by 1pm PST today, I'd like to include this in 55.0b1.

	(no longer active) Assignee
	Comment 2 • 7 years ago

This bug is due to the fact that the CSS selectors added in bug 1357656 do not select anything if there is no dir attribute on the tab-label-container element.  That is the case when the tab has no title yet (when we display the New Tab string in the tab title), that is before _setTabTitle() has ever been called.  In that case, the string is coming from the browser localization, so we should be abiding by the locale direction.

	(no longer active) Assignee
	Comment 3 • 7 years ago

(In reply to Ritu Kothari (:ritu) from comment #1)
> Tracked for 55. If we can get a fix landed by 1pm PST today, I'd like to
> include this in 55.0b1.

How should I land it for 55?  Should I request uplift?  Or something else?

	(no longer active) Assignee
	Comment 5 • 7 years ago

Comment on attachment 8876753 [details] [diff] [review]
Use the browser UI direction to set the fade-out direction for the New Tab string in tab titles

See the approval request in bug 1357656, this needs to be uplifted alongside it for 54.0.1.

	Mike Conley (:mconley) (:⚙️)
	Comment 6 • 7 years ago

Comment on attachment 8876753 [details] [diff] [review]
Use the browser UI direction to set the fade-out direction for the New Tab string in tab titles

Review of attachment 8876753 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this fixes the issue for me (and doesn't re-open bug 1357656).

	Pulsebot
	Comment 7 • 7 years ago

Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be5745a13ea4
Use the browser UI direction to set the fade-out direction for the New Tab string in tab titles; r=mconley

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 8 • 7 years ago

(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #3)
> (In reply to Ritu Kothari (:ritu) from comment #1)
> > Tracked for 55. If we can get a fix landed by 1pm PST today, I'd like to
> > include this in 55.0b1.
> 
> How should I land it for 55?  Should I request uplift?  Or something else?

Yes, please nominate the fix for uplift to m-b and m-r. I'll A+ m-b landing today. For m-r, we'll take it when we are closer to gtb 54.0.1

	(no longer active) Assignee
	Comment 9 • 7 years ago

Comment on attachment 8876753 [details] [diff] [review]
Use the browser UI direction to set the fade-out direction for the New Tab string in tab titles

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1357656
[User impact if declined]: Comment 0
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Not really, I've tested it
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Because it's simple
[String changes made/needed]: None

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 10 • 7 years ago

Comment on attachment 8876753 [details] [diff] [review]
Use the browser UI direction to set the fade-out direction for the New Tab string in tab titles

Recent regression, Beta55+

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/4281d28ef7ac

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 12 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/be5745a13ea4

	Itiel
	Comment 13 • 7 years ago

I can confirm this is fixed on latest Nightly (56.0a1 (2017-06-13)), Windows 10.

	Ciprian Georgiu, Desktop QA
	Comment 14 • 7 years ago

Reproduced this issue on Nightly 55.0a1 (2017-06-11) using Ubuntu 16.04 x64.

This bug is also verified on 55.0b2 (20170615133456) on the following OSes: Win 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.11.6.

	Gerry Chang [:gchang]
	Comment 15 • 7 years ago

Comment on attachment 8876753 [details] [diff] [review]
Use the browser UI direction to set the fade-out direction for the New Tab string in tab titles

Fix a tab regression. Release54+. Should be in 54.0.1.

	(no longer active) Assignee
	Comment 16 • 7 years ago

(Rebased for release)

	(no longer active) Assignee
	Comment 17 • 7 years ago

Please read bug 1357656 comment 50 before uplifting to the release repository.  Thanks in advance!

	Ryan VanderMeulen [:RyanVM]
	Comment 18 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-release/rev/6dcfa5094a4b

	[SV Manager] Florin Mezei, QA (:FlorinMezei)
	Comment 19 • 7 years ago

Setting for verification in 54.0.1 as well.

	Ciprian Georgiu, Desktop QA
	Comment 20 • 7 years ago

Verified fixed on 54.0.1 (20170628075643) as well, across platforms: Win 10 x64, Mac OS X 10.11.6 and Ubuntu 14.04 x64 LTS.