Closed Bug 1370857 Opened 7 years ago Closed 7 years ago

Remove Marionette.clear_imported_scripts API

Categories

(Remote Protocol :: Marionette, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(2 files)

The import script functionality was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1368648, but the Marionette.clear_imported_script API was not removed from the client.

We are currently making calls after every test (!) to the clearImportedScripts command in the server, but we are apparently ignoring the ‘unknown command’ error that is being returned.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Depends on: 1368648
Comment on attachment 8875265 [details]
Bug 1370857 - Remove Marionette.clear_imported_scripts API;

https://reviewboard.mozilla.org/r/146660/#review150720
Attachment #8875265 - Flags: review?(dburns) → review+
Comment on attachment 8875266 [details]
Bug 1370857 - Remove Marionette.import_script API;

https://reviewboard.mozilla.org/r/146662/#review150722
Attachment #8875266 - Flags: review?(dburns) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s e969912ce866 -d 9e2113a451b7: rebasing 400514:e969912ce866 "Bug 1370857 - Remove Marionette.clear_imported_scripts API; r=automatedtester"
merging testing/marionette/client/marionette_driver/marionette.py
merging testing/marionette/harness/marionette_harness/marionette_test/testcases.py
warning: conflicts while merging testing/marionette/harness/marionette_harness/marionette_test/testcases.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s cc8483d6df0d -d 47f43b453c2d: rebasing 400750:cc8483d6df0d "Bug 1370857 - Remove Marionette.clear_imported_scripts API; r=automatedtester"
merging testing/marionette/client/marionette_driver/marionette.py
merging testing/marionette/harness/marionette_harness/marionette_test/testcases.py
warning: conflicts while merging testing/marionette/harness/marionette_harness/marionette_test/testcases.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0dac00039fda
Remove Marionette.clear_imported_scripts API; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/6b37ea6c7ad1
Remove Marionette.import_script API; r=automatedtester
https://hg.mozilla.org/mozilla-central/rev/0dac00039fda
https://hg.mozilla.org/mozilla-central/rev/6b37ea6c7ad1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: