David Burns :automatedtester Assignee
	Description • 7 years ago

We need to have Window Maximising wdspec tests

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 1 • 7 years ago

Shouldn't we add those as wpt tests now that geckodriver is in tree?

	Andreas Tolfsen ❲:ato❳
	Comment 2 • 7 years ago

(In reply to Henrik Skupin (:whimboo) from comment #1)
> Shouldn't we add those as wpt tests now that geckodriver is in tree?

I think that’s exactly what David said in the description.

	David Burns :automatedtester Assignee
	Comment 3 • 7 years ago

(In reply to Henrik Skupin (:whimboo) from comment #1)
> Shouldn't we add those as wpt tests now that geckodriver is in tree?

Yup, thats why I said we need wdspec tests :)

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 4 • 7 years ago

So moving the bug into the right component.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 5 • 7 years ago

As talked in our meeting yesterday we will keep wdspec test writing in the Marionette component.

	Andreas Tolfsen ❲:ato❳
	Comment 7 • 7 years ago
mozreview-review

Comment on attachment 8881449 [details]
Bug 1370223: Add Window Maximize wdspec tests

https://reviewboard.mozilla.org/r/152584/#review157706

::: testing/web-platform/tests/webdriver/window_resizing_and_positioning.py:1
(Diff revision 1)
> +from support.inline import inline

I think we should rename this file according to the command’s name, so maximize_window.py.

The reason is that working on the other tests has shown we are quite likely to hit the maximum timeout quite easily with wdspec, so in anticipation of this—knowing how expensive it is to run tests for Set Window Rect—we should have a separate file testing the Maximize Window command, I think.

::: testing/web-platform/tests/webdriver/window_resizing_and_positioning.py:16
(Diff revision 1)
> +def test_maximize_rect_alert_prompt(session):
> +    # Step 2
> +    session.url = alert_doc
> +
> +    result = session.transport.send("POST", "session/%s/window/maximize" % session.session_id)
> +
> +    assert_error(result, "unexpected alert open")

This is not very extensive compared to our other tests, but I have a patch for this locally.  I’m happy to land this first and integrate my changes into this file later.  Sound OK?

	Pulsebot
	Comment 10 • 7 years ago

Pushed by dburns@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/25ee2110abb7
Add Window Maximize wdspec tests r=ato

	Carsten Book [:Tomcat]
	Comment 11 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/25ee2110abb7