Dylan Hardison [:dylan] (he/him) Reporter
	Description • 7 years ago

I think it will ease the branding effort (among other things) if we can unify the CSS files.

This would mean appending the content of
https://github.com/mozilla-bteam/bmo/blob/master/skins/custom/index.css
https://github.com/mozilla-bteam/bmo/blob/master/skins/contrib/Mozilla/index.css
(in that order)

to the end of https://github.com/mozilla-bteam/bmo/blob/master/skins/standard/index.css

and so on for all the files under skins/custom and skins/contrib/Mozilla.

	Dylan Hardison [:dylan] (he/him) Reporter
	Comment 1 • 7 years ago

As long as the ordering of the rules in the CSS files is the same, this should have no impact.
After this, it should be possible to use CSS developer tools to remove unneeded CSS rules as well.

	Dylan Hardison [:dylan] (he/him) Reporter
	Comment 2 • 7 years ago • Edited

note the ordering is standard, then skin, then custom. 

basically, for each one, concatate together and append to the standard one. Like the shell command below:

cat skins/contrib/Mozilla/index.css skins/custom/index.css >> skins/standard/index.css

	Dylan Hardison [:dylan] (he/him) Reporter
	Comment 4 • 7 years ago

Comment on attachment 8874542 [details] [review]
PR

Changes requested in the pull request.

	Dylan Hardison [:dylan] (he/him) Reporter
	Comment 5 • 7 years ago

Additional review cycled happened, with only one problem. I'm going to open this up for QA on bugzilla-dev so there are a few more eyes to catch changes.

	Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo
	Comment 6 • 7 years ago

I found one small thing, the background color is missing from the bug list header.

	Dylan Hardison [:dylan] (he/him) Reporter
	Comment 7 • 7 years ago

This seems to be the case in production as well -- not a bug?

	Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo
	Comment 8 • 7 years ago

Yes, no worries!