Florian Quèze [:florian] Assignee
	Description • 7 years ago

Currently marionette.js starts its initialization right after receiving the "sessionstore-windows-restored" notification.

This is unfortunate for the browser_startup.js browser chrome mochitest I added in bug 1358798, because it causes lots of marionette file to appear to be loaded before the browser is ready to handle user events.

	Florian Quèze [:florian] Assignee
	Comment 1 • 7 years ago

Tree seems green-ish: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0fa95d744f7ecc52f7d105b4d37ecc2a235010c

	Andreas Tolfsen ❲:ato❳
	Comment 2 • 7 years ago

Comment on attachment 8873807 [details] [diff] [review]
Patch

Review of attachment 8873807 [details] [diff] [review]:
-----------------------------------------------------------------

r+wc: Please expand commit message with information about the motivation and reason behind this change.

	Andreas Tolfsen ❲:ato❳
	Comment 3 • 7 years ago

Comment on attachment 8873807 [details] [diff] [review]
Patch

Review of attachment 8873807 [details] [diff] [review]:
-----------------------------------------------------------------

r+wc: Please expand commit message with information about the motivation and reason behind this change.

	Pulsebot
	Comment 4 • 7 years ago

Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3f93870b233
Delay initialization of marionette.js until delayed startup and startup tests are finished, r=ato.

	Dão Gottwald [:dao]
	Comment 5 • 7 years ago

Any particular reason why you used idleDispatch rather than explicitly observing the delayed startup finished notification?

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 6 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a3f93870b233

	Florian Quèze [:florian] Assignee
	Comment 7 • 7 years ago

(In reply to Dão Gottwald [::dao] from comment #5)
> Any particular reason why you used idleDispatch rather than explicitly
> observing the delayed startup finished notification?

There's a lot of stuff that observes the delayed-startup-notification, and cause jank at that point. We are really done with startup once the stuff started from that notification is finished, which means when the event queue is empty. That's what idleDispatch gives us.

	Florian Quèze [:florian] Assignee
	Comment 8 • 7 years ago

(In reply to Florian Quèze [:florian] [:flo] from comment #7)
> (In reply to Dão Gottwald [::dao] from comment #5)
> > Any particular reason why you used idleDispatch rather than explicitly
> > observing the delayed startup finished notification?
> 
> There's a lot of stuff that observes the delayed-startup-notification,

I meant sessionstore-windows-restored.

Also, the code modified by this patch is already running off that notification.