Treeherder Bug Filer Reporter
	Description • 7 years ago
treeherder

Filed by: rvandermeulen [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=101339461&repo=autoland

https://queue.taskcluster.net/v1/task/Yqj9ryXsR3O4NsY-dcE4yA/runs/0/artifacts/public/logs/live_backing.log

Permafailing since bug 1364594 landed.

	Brendan Dahl [:bdahl] Assignee
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8870571 [details]
Bug 1367227: Disable Marionette window maximize tests in headless mode;

https://reviewboard.mozilla.org/r/142030/#review145684

	Pulsebot
	Comment 3 • 7 years ago

Pushed by dburns@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b4c8ed50e42
Disable Marionette window maximize tests in headless mode; r=bdahl

	Pulsebot
	Comment 4 • 7 years ago

Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/72ed8fb02c63
Disable Marionette window rect tests in headless mode. r=bdahl

	Pulsebot
	Comment 5 • 7 years ago

Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/93f307b9b328
Fix incorrect syntax. r=me

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 7 years ago

The oranges are gone now, but let's leave this bug open for the eventual fixing & re-enabling.

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 8 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/2b4c8ed50e42
https://hg.mozilla.org/mozilla-central/rev/72ed8fb02c63
https://hg.mozilla.org/mozilla-central/rev/93f307b9b328

	Brendan Dahl [:bdahl] Assignee
	Comment 9 • 7 years ago

During MakeFullScreen, headless wasn't triggering a size mode and full screen changed event which caused marionette to hang waiting for a resize event. I tried to match more of the behavior of the linux and windows backend with the new code.

	Brendan Dahl [:bdahl] Assignee
	Comment 10 • 7 years ago

As mentioned on IRC, the current code doesn't actually emulate what  "View > Enter Full Screen" does and it will cause the browser to immediately try to exit fullscreen mode because it triggers the event on a chrome window and it's expected to be on a content window (follow aBrowser in [1]). This doesn't seem to be an issue on various platforms because the exit is ignored while the full screen transition is in progress. The new way does was browser.js does [2].

[1] http://searchfox.org/mozilla-central/rev/a14524a72de6f4ff738a5e784970f0730cea03d8/browser/base/content/browser-fullScreenAndPointerLock.js#429
[2] http://searchfox.org/mozilla-central/rev/a14524a72de6f4ff738a5e784970f0730cea03d8/browser/base/content/browser.js#3229

	Brendan Dahl [:bdahl] Assignee
	Comment 11 • 7 years ago

And a try run (still waiting on MacOS, but looks good elsewhere): https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f02bdaab6bc45545ea9dbe6ed1fdd8282f39bc5

	Brendan Dahl [:bdahl] Assignee
	Comment 13 • 7 years ago

Looks like I should have waited on those osx jobs... It appears that some of the resize events on mac come before the fullscreen transition is complete. I've switched it to now use sizemodechange, as that seems like the more reliable way.

	Brendan Dahl [:bdahl] Assignee
	Comment 14 • 7 years ago

And the try run again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dabd4a550d1ec5d3fbc3623f76ada52a3e86fea&group_state=expanded

	Andreas Tolfsen ❲:ato❳
	Comment 15 • 7 years ago

Comment on attachment 8872840 [details] [diff] [review]
Part 2 - Trigger fullscreen the same way Firefox does.

Review of attachment 8872840 [details] [diff] [review]:
-----------------------------------------------------------------

r+, push when confident.

	Pulsebot
	Comment 16 • 7 years ago

Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a78af3f0280
Part 1 - Match headless fullscreen behavior to other widget backends. r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/812a3f2737d4
Part 2 - Trigger fullscreen the same way Firefox does. r=ato

	Carsten Book [:Tomcat]
	Comment 17 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/8a78af3f0280
https://hg.mozilla.org/mozilla-central/rev/812a3f2737d4

	Andreas Tolfsen ❲:ato❳
	Comment 18 • 6 years ago

Oranges are gone.

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 19 • 6 years ago

No known fix -> WFM.