Andreas Tolfsen ❲:ato❳ Assignee
	Description • 7 years ago

libxss-dev is required for compiling Firefox and missing from `./mach bootstrap`.

	Gregory Szorc [:gps]
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8870386 [details]
Bug 1367032 - Bootstrap libxss-dev on Debian;

https://reviewboard.mozilla.org/r/141836/#review146196

It isn't clear to me what feature relies on this because `mach build` with no mozconfig works out of the box without this change. Should we change our default configure settings to enable whatever optional feature currently relies on libxss-dev?

	Mike Hommey [:glandium]
	Comment 3 • 7 years ago

libxss-dev, strictly speaking, is *not* required for compiling Firefox. You can build Firefox just fine without it (it's not installed on my machine, for instance). The only difference having libxss-dev installed makes is that the screenshot tool from testing/tools/screenshot uses it when it's available. That tool is used on automation to grab screenshot of failed tests, I think.

So I don't really see a reason to land this.

	Gregory Szorc [:gps]
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8870386 [details]
Bug 1367032 - Bootstrap libxss-dev on Debian;

https://reviewboard.mozilla.org/r/141836/#review146198

Changing to r- per glandium's comment.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 5 • 7 years ago

(In reply to Mike Hommey [:glandium] from comment #3)
> libxss-dev, strictly speaking, is *not* required for compiling Firefox. You
> can build Firefox just fine without it (it's not installed on my machine,
> for instance). The only difference having libxss-dev installed makes is that
> the screenshot tool from testing/tools/screenshot uses it when it's
> available. That tool is used on automation to grab screenshot of failed
> tests, I think.
> 
> So I don't really see a reason to land this.

`./mach build` fails on a default Debian installation if libxss-dev is not
installed.  I think this means that testing/tools/screenshot is compiled by
default, which it may not should be?

	Mike Hommey [:glandium]
	Comment 6 • 7 years ago

You'll have to provide a build log, because as I said, it works on my machine. And testing/tools/screenshot compiles fine when libxss-dev is not installed. There are #ifdefs removing the code that uses it when it's not there.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 7 • 7 years ago

Purging libxss-dev and x11proto-scrnsaver-dev, I’m no longer able to reproduce this.  The reason I filed the bug in the first place was because I had a build failure on this after setting up my new machine.  I… don’t exactly know what has changed in the interim.