Closed
Bug 1366366
Opened 7 years ago
Closed 7 years ago
Remove animation from new robot icon as introduced in bug
Categories
(Remote Protocol :: Marionette, defect, P2)
Remote Protocol
Marionette
Tracking
(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | --- | fixed |
People
(Reporter: whimboo, Assigned: ato)
References
Details
(Keywords: regression)
Attachments
(2 files)
Since the patch on bug 1355890 landed we see a lot of test failures for the full screenshot test on bug 1364762. As investigation on bug 1364762 has shown this happens because the robot is animated (rolling eyes). I wonder if we should better remove this animation.
Flags: needinfo?(ato)
Assignee | ||
Updated•7 years ago
|
Priority: -- → P2
Reporter | ||
Comment 2•7 years ago
|
||
Andreas, this is the reason for bug 1364762 which has a massive increase of failures. For last week it's the #3 top OF failure. So we need to remove the animation or skip the test ASAP. Thanks.
Assignee: nobody → ato
Flags: needinfo?(ato)
Reporter | ||
Comment 3•7 years ago
|
||
Also it looks like that we overdraw the location bar border.
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8870394 [details] Bug 1366366 - Use non-animated robot icon with Marionette; https://reviewboard.mozilla.org/r/141844/#review145490 rs=me, but can we either name this 'static-robot' or something, or rename the other icon, to avoid this happening to other people who accidentally use the 'wrong' icon? :-)
Attachment #8870394 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d90b1a36e1a Use non-animated robot icon with Marionette; r=Gijs
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5d90b1a36e1a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•