Andreas Tolfsen ❲:ato❳ Assignee
	Description • 7 years ago

We currently wrap all Marionette implementation errors, such as TypeError/ReferenceError et al., as a generic WebDriverError.  The WebDriverError is encoded as with the ‘webdriver error’ error code, but it does not officially exist in the specification.

It is also a problem that we mask implementation errors as a generic error to the clients.  They should technically be encoded as UnknownError, which is closer to what they actually represent.

	David Burns :automatedtester
	Comment 3 • 7 years ago
mozreview-review

Comment on attachment 8865425 [details]
Bug 1362992 - Wrap implementation errors as UnknownError

https://reviewboard.mozilla.org/r/137096/#review140266

::: testing/marionette/test_message.js:165
(Diff revision 2)
> +});
> +
> +add_test(function test_Response_sendError_body() {
> +  let resp = new Response(42, r => equal(null, r.body));
> +  resp.sendError(new WebDriverError());
> +

Do we have an assert that we can add to this test?

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 4 • 7 years ago
mozreview-review-reply

Comment on attachment 8865425 [details]
Bug 1362992 - Wrap implementation errors as UnknownError

https://reviewboard.mozilla.org/r/137096/#review140266

> Do we have an assert that we can add to this test?

The assertion happens in the response handler callback that is passed as the second argument to Response:

> r => equal(null, r.body)

This tests that the body that is passed to the function responsible for sending the response over the transport socket is empty.

	David Burns :automatedtester
	Comment 6 • 7 years ago
mozreview-review

Comment on attachment 8865425 [details]
Bug 1362992 - Wrap implementation errors as UnknownError

https://reviewboard.mozilla.org/r/137096/#review142042

	Pulsebot
	Comment 7 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99102478f0c7
Wrap implementation errors as UnknownError r=automatedtester

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 8 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/99102478f0c7