jeremy9856 Reporter
	Description • 7 years ago

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170420084331

Steps to reproduce:

Hello,

Firefox doesn't release memory after closing some tabs. The Web Content process release the memory only when you open an empty tab and close all the other one. I tried in safe mode but it's the same.

I'm on Fedora 25, Firefox 53.

Here is my user.js

user_pref("layers.acceleration.force-enabled", true);
user_pref("browser.tabs.remote.autostart", true);
user_pref("browser.tabs.remote.force-enable", true);
user_pref("extensions.pocket.enabled", false);
user_pref("privacy.trackingprotection.enabled", true);
user_pref("browser.safebrowsing.enabled", false);
user_pref("browser.safebrowsing.malware.enabled", false);
user_pref("dom.event.clipboardevents.enabled", true);
user_pref("browser.tabs.loadBookmarksInBackground", true);
user_pref("reader.parse-on-load.enabled", false);
user_pref("plugins.navigator_hide_disabled_flash", true);

Thanks !

	jeremy9856 Reporter
	Comment 1 • 7 years ago

memory not released

	jeremy9856 Reporter
	Comment 2 • 7 years ago

memory released

	jeremy9856 Reporter
	Comment 3 • 7 years ago

It's quite important because you run out of memory (4Gb) after a day of work and need to close all tabs (or Firefox).

	Andre Klapper
	Comment 4 • 7 years ago

jeremy9856: Please do not fiddle with the Priority value when you are not involved in doing the actual work. Thanks.

	:Gijs (he/him)
	Comment 5 • 7 years ago

It's really not clear this bug is anything to do with the tabbrowser itself, moving back for triage.

	Alin Rus
	Comment 6 • 7 years ago

Hello,
I was able to reproduce this release memory issue with 20170522030207 build, running on Windows 10 Pro, x64.

	Alin Rus
	Comment 7 • 7 years ago

Steps to reproduce:
1. Launch mozilla nightly build.
2. Make sure that you have at least three tabs opened (used in test: http://cnn.com, http://www.eurosport.com/, http://www.bbc.com).
3. Open Task Manager.
4. Observe memory usage when closing first tab and second one.

Expected results:
Release memory is reflected in Task Manager.

Actual results:
Memory usage keeps increasing before is stabilized.

	Alin Rus
	Comment 8 • 7 years ago

Maybe someone with more experience regarding the process of memory cleaning could provide more feedback for this issue.

Kind regards,
Alin

	Justin Dolske [:Dolske]
	Comment 9 • 7 years ago

Moving to Core::Untriaged -- I suspect this needs further investigation before pinning it as a problem specific to the memory allocator?

	Eric Rahm [:erahm]
	Comment 10 • 7 years ago

(In reply to jeremy9856 from comment #0)
> User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:53.0) Gecko/20100101
> Firefox/53.0
> Build ID: 20170420084331
> 
> Steps to reproduce:
> 
> Hello,
> 
> Firefox doesn't release memory after closing some tabs. The Web Content
> process release the memory only when you open an empty tab and close all the
> other one. I tried in safe mode but it's the same.

This is expected behavior, the web content process will stay open with e10s enabled. The only way to force close it is with the method you noted.

Please note that in newer versions we have "e10s-multi" which means you can have up to 4 web content processes. If you have for tabs open I would expect for web content processes, if you close 3 of those I would expect 1-2 web content processes to remain.

So to clarify, is the problem that when you closed a few tabs memory didn't go down? The best way to measure that is to take a memory report with the tabs open, close the tabs, *wait a few minutes*, measure again. I'd expect the memory to go down, if it does not you can try the 'minimize memory usage' button in about:memory and measure again. If the results are not satisfactory can you upload those memory reports?

Another note: from your memory report it looks like a fair amount is allocated for images:

> 642.28 MB (100.0%) -- explicit
> ├──487.16 MB (75.85%) -- images
> │  ├──486.58 MB (75.76%) -- content
> │  │  ├──485.39 MB (75.57%) -- raster/used
> │  │  │  ├──267.54 MB (41.65%) -- image(1302x802, <anonymized-1>)
> │  │  │  │  ├──260.33 MB (40.53%) -- locked
> │  │  │  │  │  ├──256.34 MB (39.91%) ── surface(1302x802 (animation))/decoded-heap
> │  │  │  │  │  └────3.98 MB (00.62%) ── surface(1302x802, compositing frame)/decoded-heap
> │  │  │  │  └────7.21 MB (01.12%) ── source
> │  │  │  ├──189.64 MB (29.53%) -- image(2640x1408, <anonymized-6>)
> │  │  │  │  ├──186.80 MB (29.08%) -- locked
> │  │  │  │  │  ├──172.62 MB (26.88%) ── surface(2640x1408 (animation))/decoded-heap
> │  │  │  │  │  └───14.18 MB (02.21%) ── surface(2640x1408, compositing frame)/decoded-heap
> │  │  │  │  └────2.84 MB (00.44%) ── source
> │  │  │  ├───24.26 MB (03.78%) -- image(582x256, <anonymized-14>)
> │  │  │  │   ├──22.13 MB (03.45%) -- locked
> │  │  │  │   │  ├──21.56 MB (03.36%) ── surface(582x256 (animation))/decoded-heap
> │  │  │  │   │  └───0.57 MB (00.09%) ── surface(582x256, compositing frame)/decoded-heap
> │  │  │  │   └───2.13 MB (00.33%) ── source
> │  │  │  └────3.96 MB (00.62%) ++ (12 tiny)
> │  │  └────1.19 MB (00.19%) ++ vector/used
> │  └────0.58 MB (00.09%) ++ (2 tiny)

It's possible we have a leak there, but the odds are you're on a website that's rendering a few large images, which is also expected behavior.

	jeremy9856 Reporter
	Comment 11 • 7 years ago

(In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment #10)
> So to clarify, is the problem that when you closed a few tabs memory didn't
> go down? 

Yes. When you close a tab the memory used by this tab should be freed. That not the case even after minutes or hours, because, like I said in comment 3, I run out of memory (4Gb) after a day of work and need to close all tabs (or Firefox) to get back my memory ! I will upload some memory reports when I will have the time but you should see it by yourself just by opening a lot a tabs and closing them except one.

> Another note: from your memory report it looks like a fair amount is
> allocated for images.
> It's possible we have a leak there, but the odds are you're on a website
> that's rendering a few large images, which is also expected behavior.

I don't remember what site I browsed. I will make some tests if I have time.

	jeremy9856 Reporter
	Comment 16 • 7 years ago

Here is 4 logs. 

1. I opened something like 20 tabs (without a lot of images, mostly archwiki) and made memory-report-before.json.gz

2. I closed most of the tabs (leave something like 4 opened) and made memory-report-just-after.json.gz

3. I waited 15mn without using Firefox and made memory-report-15mn-after.json.gz

4. I used a little bit Firefox for 1h without opening new tabs and made memory-report-1h-after.json.gz

Hope it help :)

	Eric Rahm [:erahm]
	Comment 17 • 7 years ago

Comparing #1 with #3 the memory usage goes down after closing the tabs, I'm not sure what the issue is at this point. The amount would be larger but there's a fair amount in bin-unused; this is expected and is memory that will be reused when you open more tabs.

	jeremy9856 Reporter
	Comment 18 • 7 years ago

You are right, in #3 the memory goes down but not enough. In Gnome system monitor Firefox took about 350Mb and Web Content about 600Mb with all tabs opened. In #3 still in Gnome system monitor Firefox took about 350Mb and Web Content 400Mb with only 4 tabs remaining open. So I repeat, the problem is, after a day of use the unreleased memory pile up and Firefox consume far too much memory.

	Firefox Bug Husbandry Bot
	Comment 19 • 7 years ago

Moving from Core::Untriaged to Core::General https://bugzilla.mozilla.org/show_bug.cgi?id=1407598