Ian Bicking (:ianbicking) Reporter
	Description • 7 years ago

This is a followup from an issue submitted to Screenshots: https://github.com/mozilla-services/screenshots/issues/2818

In Screenshots, when the user clicks on the download link it sends a message to the background page which initiates a download using browser.downloads.download (code: https://github.com/mozilla-services/screenshots/blob/cba6f750a522868c543d0fe0c5439993da69d4fd/addon/webextension/background/main.js#L267 )

Because the download is initiated from the background page it's not associated with any window, and gets put in the non-private-window download manager.

Perhaps the background page could indicate the tabId where the download originated from as an option to download.downloads.

	Rob Wu [:robwu] Assignee
	Comment 1 • 7 years ago

FVD wants this.

	John Gruen [:jgruen]
	Comment 3 • 7 years ago

Not sure if this is relevant but: https://bugzilla.mozilla.org/show_bug.cgi?id=1380809

	Andrew Swan [:aswan]
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8886611 [details]
Bug 1362448 - Support "incognito" in downloads.create

https://reviewboard.mozilla.org/r/157426/#review162988

Looks good, thanks!

::: toolkit/components/extensions/ext-downloads.js:528
(Diff revision 1)
>            return Downloads.getPreferredDownloadsDirectory()
>              .then(downloadsDir => createTarget(downloadsDir))
>              .then(target => {
>                const source = {
>                  url: options.url,
> +                isPrivate: options.incognito === true,

You can put `"default": false` into the schema and then just take the value from `options.incognito` here.

	Pulsebot
	Comment 6 • 7 years ago

Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/f257d10ebc4a
Support "incognito" in downloads.create r=aswan

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 7 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f257d10ebc4a

	Will Bamberg [:wbamberg]
	Comment 10 • 7 years ago

I've noted this in https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/downloads/download and have a PR to update the compat data: https://github.com/mdn/browser-compat-data/pull/421

Let me know if we need anything else here.

	Rob Wu [:robwu] Assignee
	Comment 11 • 7 years ago

LGTM. Thanks Will!

	marius.santa
	Comment 12 • 7 years ago

I can reproduce this issue on Firefox 57.0b3 (20170925150345) under Wind 10 64-bit. 

This issue is verified as fixed on Firefox 57.0b14 (20171102181127), 58.0a1 (20171106100122) under Wind 10 64-bit and Mac OS X 10.13.