Closed
Bug 1361464
Opened 7 years ago
Closed 7 years ago
Restore previous comment fonts, conditionally select "Fira" for Windows clients
Categories
(bugzilla.mozilla.org :: General, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dylan, Assigned: dylan)
Details
Attachments
(1 file)
1.54 KB,
patch
|
emceeaich
:
review+
|
Details | Diff | Splinter Review |
The font used for comments is a rather finicky issue across OS and browser, and having to wait on a push means we're slow to iterate. I'm going to provide a temporary solution to adjust this based on an admin param so that we can try out fonts quickly.
Assignee | ||
Comment 1•7 years ago
|
||
After a lot of thinking (and testing on different linux distros) I find the previous rule: font: 13px/1.2 "Droid Sans Mono",Menlo,Monaco,"Courier New",Courier,monospace; works best on the majority of platforms, except windows. In fact, "monospace" results in menlo on macOS and Droid Sans Mono on older android devices. The main problem is that "monospace" on windows is Courier New and is difficult to read... With that in mind, I will restore the previous rule and allow a user prefer to override the default windows font with Fira Mono, which is a reasonable replacement.
Summary: Provide runtime configuration of comment fonts to fine-tune user experience → Restore previous comment fonts, conditionally select "Fira" for Windows clients, and allow this to be disabled
Assignee | ||
Updated•7 years ago
|
Summary: Restore previous comment fonts, conditionally select "Fira" for Windows clients, and allow this to be disabled → Restore previous comment fonts, conditionally select "Fira" for Windows clients
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8863932 -
Flags: review?(ehumphries)
Comment on attachment 8863932 [details] [diff] [review] 1361464_1.patch Review of attachment 8863932 [details] [diff] [review]: ----------------------------------------------------------------- Also cover the Win64 case, but :shipit:
Attachment #8863932 -
Flags: review?(ehumphries) → review+
Assignee | ||
Comment 4•7 years ago
|
||
To git@github.com:mozilla-bteam/bmo.git 96ef286..8be2b9a master -> master
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•