Ryan VanderMeulen [:RyanVM] Assignee
	Description • 7 years ago

Over in bug 1325942, test_formdataparsing.html and test_formdataparsing_sw_reroute.html had to be disabled on ASAN because they were triggering permaleaks with LeakSanitizer.

To make tracking easier, this bug is being filed to track finding and fixing the root cause of the leaks so those tests can be re-enabled.

The leaks took the form of:

==1866==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 13824 byte(s) in 96 object(s) allocated from:
    #0 0x4b2e4b in malloc /builds/slave/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:52:3
    #1 0x7fe4dff45eee in maybe_pod_malloc<unsigned char> /src/obj-firefox/dist/include/mozilla/AllocPolicy.h:80:28
    #2 0x7fe4dff45eee in pod_malloc<unsigned char> /src/obj-firefox/dist/include/mozilla/AllocPolicy.h:101
    #3 0x7fe4dff45eee in convertToHeapStorage /src/obj-firefox/dist/include/mozilla/Vector.h:936
    #4 0x7fe4dff45eee in mozilla::Vector<unsigned char, 0ul, mozilla::MallocAllocPolicy>::growStorageBy(unsigned long) /src/obj-firefox/dist/include/mozilla/Vector.h:1027
    #5 0x7fe4e03c2cb8 in append<char> /src/obj-firefox/dist/include/mozilla/Vector.h:1353:9
    #6 0x7fe4e03c2cb8 in append<char> /src/obj-firefox/dist/include/mozilla/Vector.h:1414
    #7 0x7fe4e03c2cb8 in mozilla::net::nsStreamLoader::WriteSegmentFun(nsIInputStream*, void*, char const*, unsigned int, unsigned int, unsigned int*) /src/netwerk/base/nsStreamLoader.cpp:137
    #8 0x7fe4e010039c in nsPipeInputStream::ReadSegments(nsresult (*)(nsIInputStream*, void*, char const*, unsigned int, unsigned int, unsigned int*), void*, unsigned int, unsigned int*) /src/xpcom/io/nsPipe3.cpp:1431:12
    #9 0x7fe4e03c31c9 in mozilla::net::nsStreamLoader::OnDataAvailable(nsIRequest*, nsISupports*, nsIInputStream*, unsigned long, unsigned int) /src/netwerk/base/nsStreamLoader.cpp:153:10

	Marion Daly [:mdaly]
	Comment 1 • 6 years ago

Backlog.

	Pulsebot
	Comment 5 • 2 years ago

Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52bfbf43dfa4
Re-enable test_formdataparsing.html and test_formdataparsing_sw_reroute.html on ASAN. r=dom-storage-reviewers,janv