Closed
Bug 1359054
Opened 7 years ago
Closed 7 years ago
Take shadow DOM into account when getting paint tree
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(1 file)
Shadow DOM is not taken into account when calling element.getPointerInteractablePaintTree from testing/marionette/element.js.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•7 years ago
|
||
Unfortunately this change is also not accompanied by any tests because the wrong behaviour does not trigger unless you run the WebDriver conforming Element Click implementation against the shadow DOM tests. This is a patch in preparation of https://bugzilla.mozilla.org/show_bug.cgi?id=1321516, but I think it is mostly sane to the reader.
Comment 3•7 years ago
|
||
Don't we have those tests in test_click.py? I can see two types and I thought that those cover that.
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #3) > Don't we have those tests in test_click.py? I can see two types and I > thought that those cover that. The shadow DOM related tests live in testing/marionette/harness/marionette_harness/tests/unit/test_shadow_dom.py and IIRC test_inner_shadow_dom fails if you run it with the patched webdriverClick command found in the patches attached to https://bugzilla.mozilla.org/show_bug.cgi?id=1321516.
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8860966 [details] Bug 1359054 - Take shadow DOM into account when getting paint tree; https://reviewboard.mozilla.org/r/132978/#review136268 *reads Shadow DOM 101* Okay, this change makes sense! :D
Attachment #8860966 -
Flags: review?(mjzffr) → review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3756fa6062d1 Take shadow DOM into account when getting paint tree; r=maja_zf
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3756fa6062d1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•